Re: supercollider FTBFS on ppc64el

--=_87384ce8cd301f95707f6a5921689ce4
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8;
 format=flowed

Dear Maintainer,

The version 3.14.0+ds-1 still FTBFS on ppc64el despite the fix uploaded 
for this bug.
Build log: 
https://buildd.debian.org/status/fetch.php?pkg=supercollider-sc3-plugins&arch=ppc64el&ver=3.13.0%7Erepack-1.2&stamp=1782753041&raw=0


Root cause:
Removing -mno-altivec/-mno-vsx in 3.14.0+ds-1 re-enabled AltiVec/VSX on 
ppc64el,
exposing a pre-existing defect in two bundled nova-simd headers:

external_libraries/nova-simd/vec/vec_altivec.hpp
external_libraries/nova-simd/vec/vec_int_altivec.hpp

current falling build log : 
https://buildd.debian.org/status/fetch.php?pkg=supercollider-sc3-plugins&arch=ppc64&ver=3.14.0%2Bds-1&stamp=1782852658&raw=0


Both include <altivec.h> and immediately open a C++ namespace.
On ppc64el, GCC defines __APPLE_ALTIVEC__, which causes <altivec.h> to 
skip its #define vector __vector macro.
The bare vector keyword then reaches the C++ parser directly, and inside 
a namespace where std::vector is also visible,
GCC 15 fails with:

error: 'vector' does not name a type; did you mean 'vec_or'?
    30 |     typedef vector float fvec;


Fix:
Replaced all bare vector usages inside the affected namespaces with 
__vector — GCC's built-in keyword,
valid at any scope regardless of __APPLE_ALTIVEC__. Added #undef 
vector/#undef pixel/#undef bool after #include <altivec.h>
as a defensive guard. Also fixed vec_re(arg) → vec_re(arg.data_), since 
the intrinsic requires a raw __vector float, not the wrapper class.


Verified on a ppc64el LPAR (Debian sid):
dpkg-buildpackage -us -uc -b  successfully builds supercollider on 
ppc64el generating below .dep files

ladspalist_3.14.0+ds-3_ppc64el.deb         
sc3-plugins-server_3.14.0+ds-3_ppc64el.deb
ladspalist-dbgsym_3.14.0+ds-3_ppc64el.deb  
sc3-plugins-server-dbgsym_3.14.0+ds-3_ppc64el.deb
sc3-plugins_3.14.0+ds-3_all.deb
sc3-plugins-language_3.14.0+ds-3_all.deb

I have shared two patches below, please review it.

I will create a Merge Request on Salsa with this patch if it looks good 
to you.

Please let me know if any changes are needed.


Thanks,
Trupti
--=_87384ce8cd301f95707f6a5921689ce4
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=fix-altivec-vector-keyword.patch
Content-Disposition: attachment;
 filename=fix-altivec-vector-keyword.patch;
 size=1136

SW5kZXg6IHN1cGVyY29sbGlkZXItc2MzLXBsdWdpbnMtMy4xNC4wK2RzL2V4dGVybmFsX2xpYnJh
cmllcy9ub3ZhLXNpbWQvdmVjL3ZlY19pbnRfYWx0aXZlYy5ocHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3Vw
ZXJjb2xsaWRlci1zYzMtcGx1Z2lucy0zLjE0LjArZHMub3JpZy9leHRlcm5hbF9saWJyYXJpZXMv
bm92YS1zaW1kL3ZlYy92ZWNfaW50X2FsdGl2ZWMuaHBwCisrKyBzdXBlcmNvbGxpZGVyLXNjMy1w
bHVnaW5zLTMuMTQuMCtkcy9leHRlcm5hbF9saWJyYXJpZXMvbm92YS1zaW1kL3ZlYy92ZWNfaW50
X2FsdGl2ZWMuaHBwCkBAIC0yMSwyMSArMjEsMjQgQEAKICNkZWZpbmUgVkVDX0lOVF9BTFRJVkVD
X0hQUAogCiAjaW5jbHVkZSA8YWx0aXZlYy5oPgorI3VuZGVmIGJvb2wKKyN1bmRlZiB2ZWN0b3IK
KyN1bmRlZiBwaXhlbAogCiBuYW1lc3BhY2Ugbm92YSB7CiBuYW1lc3BhY2UgZGV0YWlsIHsKIAog
c3RydWN0IGludF92ZWNfYWx0aXZlYwogewotICAgIHR5cGVkZWYgdmVjdG9yIGZsb2F0IGZ2ZWM7
Ci0gICAgdHlwZWRlZiB2ZWN0b3IgdW5zaWduZWQgaW50IGl2ZWM7CisgICAgdHlwZWRlZiBfX3Zl
Y3RvciBmbG9hdCBmdmVjOworICAgIHR5cGVkZWYgX192ZWN0b3IgdW5zaWduZWQgaW50IGl2ZWM7
CiAgICAgaXZlYyBkYXRhXzsKIAogcHJpdmF0ZToKICAgICBzdGF0aWMgaXZlYyBzZXRfdmVjdG9y
KGludCBpKQogICAgIHsKICNpZmRlZiBfX0dOVUNfXwotICAgICAgICByZXR1cm4gKGl2ZWMpe2ks
IGksIGksIGl9OworICAgICAgICByZXR1cm4gKGl2ZWMpeyh1bnNpZ25lZCBpbnQpaSwodW5zaWdu
ZWQgaW50KWksICh1bnNpZ25lZCBpbnQpaSwgKHVuc2lnbmVkIGludClpfTsKICNlbHNlCiAjZXJy
b3IgY29tcGlsZXIgbm90IHN1cHBvcnRlZAogI2VuZGlmCkBAIC01OCw3ICs2MSw3IEBAIHB1Ymxp
YzoKICAgICAgICAgZGF0YV8oYXJnLmRhdGFfKQogICAgIHt9CiAKLSAgICBpbnRfdmVjX2FsdGl2
ZWModmVjdG9yIHNpZ25lZCBpbnQgYXJnKToKKyAgICBpbnRfdmVjX2FsdGl2ZWMoX192ZWN0b3Ig
c2lnbmVkIGludCBhcmcpOgogICAgICAgICBkYXRhXygoaXZlYylhcmcpCiAgICAge30KIAo=
--=_87384ce8cd301f95707f6a5921689ce4
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=fix-altivec-vector-keyword1.patch
Content-Disposition: attachment;
 filename=fix-altivec-vector-keyword1.patch;
 size=3398

SW5kZXg6IHN1cGVyY29sbGlkZXItc2MzLXBsdWdpbnMtMy4xNC4wK2RzL2V4dGVybmFsX2xpYnJh
cmllcy9ub3ZhLXNpbWQvdmVjL3ZlY19hbHRpdmVjLmhwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdXBlcmNv
bGxpZGVyLXNjMy1wbHVnaW5zLTMuMTQuMCtkcy5vcmlnL2V4dGVybmFsX2xpYnJhcmllcy9ub3Zh
LXNpbWQvdmVjL3ZlY19hbHRpdmVjLmhwcAorKysgc3VwZXJjb2xsaWRlci1zYzMtcGx1Z2lucy0z
LjE0LjArZHMvZXh0ZXJuYWxfbGlicmFyaWVzL25vdmEtc2ltZC92ZWMvdmVjX2FsdGl2ZWMuaHBw
CkBAIC0yMiw2ICsyMiw4IEBACiAKICNpbmNsdWRlIDxhbHRpdmVjLmg+CiAjdW5kZWYgYm9vbAor
I3VuZGVmIHZlY3RvcgorI3VuZGVmIHBpeGVsCiAKICNpbmNsdWRlICIuLi9kZXRhaWwvdmVjX21h
dGguaHBwIgogI2luY2x1ZGUgInZlY19pbnRfYWx0aXZlYy5ocHAiCkBAIC0zOSwxMyArNDEsMTMg
QEAgbmFtZXNwYWNlIG5vdmEKIAogdGVtcGxhdGUgPD4KIHN0cnVjdCB2ZWM8ZmxvYXQ+OgotICAg
IHZlY19iYXNlPGZsb2F0LCB2ZWN0b3IgZmxvYXQsIDQ+CisgICAgdmVjX2Jhc2U8ZmxvYXQsIF9f
dmVjdG9yIGZsb2F0LCA0PgogewotICAgIHR5cGVkZWYgdmVjdG9yIGZsb2F0IGludGVybmFsX3Zl
Y3Rvcl90eXBlOworICAgIHR5cGVkZWYgX192ZWN0b3IgZmxvYXQgaW50ZXJuYWxfdmVjdG9yX3R5
cGU7CiAgICAgdHlwZWRlZiBmbG9hdCBmbG9hdF90eXBlOwogCiBwcml2YXRlOgotICAgIHR5cGVk
ZWYgdmVjX2Jhc2U8ZmxvYXQsIHZlY3RvciBmbG9hdCwgND4gYmFzZTsKKyAgICB0eXBlZGVmIHZl
Y19iYXNlPGZsb2F0LCBfX3ZlY3RvciBmbG9hdCwgND4gYmFzZTsKIAogICAgIHN0YXRpYyBpbnRl
cm5hbF92ZWN0b3JfdHlwZSBzZXRfdmVjdG9yKGZsb2F0IGYwLCBmbG9hdCBmMSwgZmxvYXQgZjIs
IGZsb2F0IGYzKQogICAgIHsKQEAgLTIzMSw3ICsyMzMsNyBAQCBwcml2YXRlOgogICAgICAgICAv
LyBhZGFwdGVkIGZyb20gaHR0cDovL2RldmVsb3Blci5hcHBsZS5jb20vaGFyZHdhcmVkcml2ZXJz
L3ZlL2FsZ29yaXRobXMuaHRtbAogCiAgICAgICAgIC8vIEdldCB0aGUgcmVjaXByb2NhbCBlc3Rp
bWF0ZQotICAgICAgICB2ZWN0b3IgZmxvYXQgZXN0aW1hdGUgPSB2ZWNfcmUoYXJnKTsKKyAgICAg
ICAgX192ZWN0b3IgZmxvYXQgZXN0aW1hdGUgPSB2ZWNfcmUoYXJnKTsKIAogICAgICAgICAvLyBP
bmUgcm91bmQgb2YgTmV3dG9uLVJhcGhzb24gcmVmaW5lbWVudAogICAgICAgICByZXR1cm4gdmVj
X21hZGQodmVjX25tc3ViKGVzdGltYXRlLCBhcmcsIGdlbl9vbmUoKSksIGVzdGltYXRlLCBlc3Rp
bWF0ZSk7CkBAIC0yODQsNyArMjg2LDcgQEAgcHVibGljOgogCiAgICAgZnJpZW5kIHZlYyBmYXN0
X3JlY2lwcm9jYWwoY29uc3QgdmVjICYgYXJnKQogICAgIHsKLSAgICAgICAgdmVjdG9yIGZsb2F0
IGVzdGltYXRlID0gdmVjX3JlKGFyZyk7CisgICAgICAgIF9fdmVjdG9yIGZsb2F0IGVzdGltYXRl
ID0gdmVjX3JlKGFyZy5kYXRhXyk7CiAgICAgICAgIHJldHVybiBlc3RpbWF0ZTsKICAgICB9CiAK
QEAgLTMxNiw4ICszMTgsOCBAQCBwdWJsaWM6CiAgICAgdmVjIG9wZXJhdG9yIG9wKHZlYyBjb25z
dCAmIHJocykgY29uc3QgXAogICAgIHsgXAogICAgICAgICBjb25zdCBpbnRlcm5hbF92ZWN0b3Jf
dHlwZSBvbmUgPSBnZW5fb25lKCk7IFwKLSAgICAgICAgdmVjdG9yIHVuc2lnbmVkIGludCBtYXNr
ID0gKHZlY3RvciB1bnNpZ25lZCBpbnQpb3Bjb2RlKGRhdGFfLCByaHMuZGF0YV8pOyBcCi0gICAg
ICAgIHJldHVybiAoaW50ZXJuYWxfdmVjdG9yX3R5cGUpdmVjX2FuZChtYXNrLCAodmVjdG9yIHVu
c2lnbmVkIGludClvbmUpOyBcCisgICAgICAgIF9fdmVjdG9yIHVuc2lnbmVkIGludCBtYXNrID0g
KF9fdmVjdG9yIHVuc2lnbmVkIGludClvcGNvZGUoZGF0YV8sIHJocy5kYXRhXyk7IFwKKyAgICAg
ICAgcmV0dXJuIChpbnRlcm5hbF92ZWN0b3JfdHlwZSl2ZWNfYW5kKG1hc2ssIChfX3ZlY3RvciB1
bnNpZ25lZCBpbnQpb25lKTsgXAogICAgIH0KIAogI2RlZmluZSB2ZWNfY21wbGVfKGEsIGIpIHZl
Y19jbXBnZShiLCBhKQpAQCAtMzY3LDcgKzM2OSw3IEBAIHB1YmxpYzoKIAogICAgIGZyaWVuZCBp
bmxpbmUgdmVjIHNlbGVjdCh2ZWMgbGhzLCB2ZWMgcmhzLCB2ZWMgYml0bWFzaykKICAgICB7Ci0g
ICAgICAgIHJldHVybiB2ZWNfc2VsKGxocy5kYXRhXywgcmhzLmRhdGFfLCAodmVjdG9yIHVuc2ln
bmVkIGludCliaXRtYXNrLmRhdGFfKTsKKyAgICAgICAgcmV0dXJuIHZlY19zZWwobGhzLmRhdGFf
LCByaHMuZGF0YV8sIChfX3ZlY3RvciB1bnNpZ25lZCBpbnQpYml0bWFzay5kYXRhXyk7CiAgICAg
fQogCiAgICAgLyogQH0gKi8KQEAgLTM5NSwxNCArMzk3LDE0IEBAIHByaXZhdGU6CiAgICAgICAg
IC8vIGFkYXB0ZWQgZnJvbSBodHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9oYXJkd2FyZWRyaXZl
cnMvdmUvYWxnb3JpdGhtcy5odG1sCiAKICAgICAgICAgLy9HZXQgdGhlIHNxdWFyZSByb290IHJl
Y2lwcm9jYWwgZXN0aW1hdGUKLSAgICAgICAgdmVjdG9yIGZsb2F0IHplcm8gPSAgICBnZW5femVy
bygpOwotICAgICAgICB2ZWN0b3IgZmxvYXQgb25lSGFsZiA9IGdlbl8wNSgpOwotICAgICAgICB2
ZWN0b3IgZmxvYXQgb25lID0gICAgIGdlbl9vbmUoKTsKLSAgICAgICAgdmVjdG9yIGZsb2F0IGVz
dGltYXRlID0gdmVjX3JzcXJ0ZShhcmcpOworICAgICAgICBfX3ZlY3RvciBmbG9hdCB6ZXJvID0g
ICAgZ2VuX3plcm8oKTsKKyAgICAgICAgX192ZWN0b3IgZmxvYXQgb25lSGFsZiA9IGdlbl8wNSgp
OworICAgICAgICBfX3ZlY3RvciBmbG9hdCBvbmUgPSAgICAgZ2VuX29uZSgpOworICAgICAgICBf
X3ZlY3RvciBmbG9hdCBlc3RpbWF0ZSA9IHZlY19yc3FydGUoYXJnKTsKIAogICAgICAgICAvL09u
ZSByb3VuZCBvZiBOZXd0b24tUmFwaHNvbiByZWZpbmVtZW50Ci0gICAgICAgIHZlY3RvciBmbG9h
dCBlc3RpbWF0ZVNxdWFyZWQgPSB2ZWNfbWFkZChlc3RpbWF0ZSwgZXN0aW1hdGUsIHplcm8pOwot
ICAgICAgICB2ZWN0b3IgZmxvYXQgaGFsZkVzdGltYXRlID0gdmVjX21hZGQoZXN0aW1hdGUsIG9u
ZUhhbGYsIHplcm8pOworICAgICAgICBfX3ZlY3RvciBmbG9hdCBlc3RpbWF0ZVNxdWFyZWQgPSB2
ZWNfbWFkZChlc3RpbWF0ZSwgZXN0aW1hdGUsIHplcm8pOworICAgICAgICBfX3ZlY3RvciBmbG9h
dCBoYWxmRXN0aW1hdGUgPSB2ZWNfbWFkZChlc3RpbWF0ZSwgb25lSGFsZiwgemVybyk7CiAgICAg
ICAgIHJldHVybiB2ZWNfbWFkZCh2ZWNfbm1zdWIoYXJnLCBlc3RpbWF0ZVNxdWFyZWQsIG9uZSks
IGhhbGZFc3RpbWF0ZSwgZXN0aW1hdGUpOwogICAgIH0KIAo=
--=_87384ce8cd301f95707f6a5921689ce4--