Re: Bug#1121530: libreoffice: Please build with -fPIE on sparc64 to fix FTBFS

Hi,

Am 28.11.25 12:02, schrieb John Paul Adrian Glaubitz:
> On Fri, 2025-11-28 at 09:46 +0100, John Paul Adrian Glaubitz wrote:
> > On Fri, 2025-11-28 at 09:34 +0100, Rene Engelhard wrote:
> > > Upstream patches related to/for lp-solve I mean:
> > > 
> > > <https://git.libreoffice.org/core/+/refs/heads/master/external/lpsolve/>
> > 
> > Yes, I'm aware of this.
> > 
> > > In any way you need to teach ccc -fPIE. But then I'd wonder why lp-solve in
> > > Debian built... That one has "just" -fPIC.
> > 
> > Please see my other mail. I said, I'm going to replace "-fpic" with "-fPIC".
> > 
> > -fpic/-fPIC is for libraries, -fpie/-fPIE for executables.
> > 
> > > See salsa.debian.org/math-team/lp-solve
> > 
> > Which confirms my theory ;-).
> 
> The attached patch replaces "-fpic" with "-fPIC" in the lp-solve build script which
> seems to be enough to fix this particular build issue on sparc64.

Can you please do some care in your "patches" so that one doesn't need to
replicate anything in them which makes the patch moot in the first place?

Here even a new patch patching ccc is not needed at all. In this case
external/lpsolve/lp_solve_5.5.patch already adds
+     pic=-fpic
itself. Which is used.

So the correct patch is
--- external/lpsolve/lp_solve_5.5.patch-old	2025-11-28 19:18:23.702374716 +0100
+++ external/lpsolve/lp_solve_5.5.patch	2025-11-28 19:18:33.730426860 +0100
@@ -28,7 +28,7 @@
 +     a=a
 +     soprefix=lib
 +     libs="-lm"
-+     pic=-fpic
++     pic=-fPIC
 +     ldflags="-Wl,-Bsymbolic -Wl,-soname,liblpsolve55.$so"
  fi

Regards,

Ren