Re: Bug#1121498: libreoffice: Preprocessor macros in pdfium confuse arm64 with sparc64

Hi,

On Tue, 2025-12-02 at 18:08 +0100, Rene Engelhard wrote:
> > On Tue, 2025-12-02 at 18:03 +0100, Rene Engelhard wrote:
> > > Am 02.12.25 um 17:58 schrieb John Paul Adrian Glaubitz:
> > > > 14:43 <ricotz> (__arch64__) sollte wohl entfernt werden -https://pd=
fium.googlesource.com/pdfium/+/refs/heads/main/core/fxcrt/numerics/safe_con=
versions.h
> > > > OK, I'll drop __arch64__ altogether then. I'm still struggling to f=
ix my Gerrit access
> > > > in the mean time to fix this issue upstream in pdfium.
> > > If I understand that one right this *is* like this upstream in master=
 already. That link is to
> > >=20
> > > https://pdfium.googlesource.com/pdfium/+/refs/heads/main
> > What do you mean? The wrong check for the __arch64__ macro is still the=
re, see:
> >=20
> > https://pdfium.googlesource.com/pdfium/+/refs/heads/main/core/fxcrt/num=
erics/safe_math_clang_gcc_impl.h#17
>=20
> Ah, right, he mentioned the gcc one where this is the clang one (which is=
 used).
>=20
>=20
> Will remove in the patch anyways.

Yeah, just drop the __arch64__ then, please.

I will take care of landing this fix upstream and also the arch definitions=
 for the
other architectures to enable the pdfium build there out of the box.

Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913