Re: Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

Mattia Rizzolo <[email protected]> Wed, 23 Oct 2019 18:28:13 +0200

Newsgroups	gmane.linux.debian.ports.superh,gmane.linux.debian.ports.68k
Message-ID	<[email protected]>

On Wed, Oct 23, 2019 at 06:23:10PM +0200, Helmut Grohne wrote:
> > Indeed. But I have not figured out yet what the issue is. I can just say
> > that building with "nocheck" currently results in a broken .pc file.
> 
> This is easy enough to diagnose. Just build it twice once without
> nocheck and once with. Compare using diffoscope. What happens is that
> the nocheck variant garbles the version:
> 
> -Version: 0.1.3
> +Version: ..
> 
> It tries to interpolate PROJECT_VERSION here. According to the cmake
> documentation, this is the version given to the most recent invocation
> of "project()". There actually are two such invocations and the second
> one is guarded by BUILD_EXAMPLES (and lacks a version). So the culprit
> is not setting BUILD_TESTS=0, but setting BUILD_EXAMPLES=1, which was
> also added by my patch (to try to make the build reproducible, but it
> failed doing so)!
> 
> So yeah, you should revert that part. Doing so will make it fail to
> cross build. Making nocheck work requires a different fix I fear.

Don't worry, as I mentioned (maybe too quickly?) in my email I already
worked on a different solution, improving the CMakeFile.txt and do what
everybody would expect :)

Now the problem is the failing autopkgtest (I should probably open a new
bug, but I'll try waiting and see if Adrian looks at it without).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

signature.asc (application/pgp-signature, 833 B)