Re: [rock-sm] 2005021712413810643 fake new

++ 17/02/05 - [email protected]:
> Open Patch: 2005021712413810643 [by fake]                    + fake
> 
> fake:
>         postgresql: add a stone module for initialization,
>         user creation and dropping and database creation and
>         dropping. comments please!
> 
> ----------------------------------------------------------------------------
> https://www.rocklinux.net/submaster/smadm.cgi?i=2005021712413810643

Hi,

Here are mine after a quick overview of the patch :
* the createuser command will ask for 2 things : if the new user is allowed 
to create databases and if it is allowed to create users. these questions 
will be asked out of stone, giving a bad user experience. i suggest using 
the parameters to createuser so that the created user is neither allowed to 
create user or databases ( --no-create-db --no-add-user) since it is the most 
frequent case. another solution would be ask within stone if the user should 
be able to create db or users.
* i am not sure that it is necessary to check for the existence of the user in /etc/passwd : 1/ createuser seems to be able to create the unix account if it does not exist 2/ users account can be elsewhere (getent passwd would be better that /etc/passwd)
* i am not sure if we should put jokes in the stone modules. i would vote against
* other common functions that could be implemented : dump a db, import sql commands from a file

/mathieu