Re: aclocal/dirlist

Hi,

On Mon, Oct 17, 2005 at 02:23:12PM +0200, Clifford Wolf wrote:
> On Tue, Oct 11, 2005 at 06:32:06PM +0200, Stepan Kasal wrote:
> > All /opt/*/share/aclocal directories should be listed in
> > /usr/share/aclocal/dirlist
> > (See "info aclocal" for details.)
> 
> What do you think about this patch to automake:
> | Clifford Wolf:
> | 	Added wildcard support to the dirlist parser
...
> With this applied we could simply add a static /usr/share/aclocal/dirlist
> file to the automake package.

I guess that if the patch will be accepted, it'll go only to HEAD, which
will eventually become Automake 1.10.

And even if the patch were accepted for 1.9 branch, are you willing to patch
Automake 1.7 and 1.8 in ROCK?

I would prefer the postinstall code, until we can suppose Automake 1.10.

Back to your patch:
> | --- automake-1.9.3/aclocal.in	2005-10-17 13:06:07.000000000 +0200
> | +++ automake-1.9.3/aclocal.in	2005-10-17 13:07:59.000000000 +0200
> | @@ -672,11 +672,11 @@
> |  	  # Ignore '#' lines.
> |  	  next if /^#/;
> |  	  # strip off newlines and end-of-line comments
> | -	  s/\s*\#.*$//;
> | +	  s/\s*\#.*$//; chomp;
> |  	  chomp ($contents=$_);
> | -	  if (-d $contents )
> | +	  foreach $contents (glob)
> |  	    {
> | -	      push (@dirlist, $contents);
> | +	      push (@dirlist, $contents) if -d $contents;
> |  	    }
> |  	}
> |        close (DEFAULT_DIRLIST);

The line "chomp ($contents=$_);" should be removed.
"foreach $contents" should probably be "foreach my $contents".

> I have sent a mail about it to the automake mailinglist already, but it
> looks like it did not come thru so far..

I have created a modified version of your patch, which applies to
Automake HEAD.  I'll post it as a followup to your mail in the Automake
lists.

Have a nice day,
	Stepan