Re: Xorg gcc40 patch and static linking

Am Montag 14 November 2005 02:18 schrieb Stefan Fiedler:
> Am Sonntag 13 November 2005 14:45 schrieb Benjamin Schieder:
> > Hi list.
> >
> > The recently added package/x11/xorg/gcc40.patch breaks static linking of
> > xorg with gcc 3.4.4.
> > Specifically this part:
> >
> > diff -dur xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_chipset.h
> > src.xorg.1129808283.2035.3041395841/xc/programs/Xserver/hw/xfree86/driver
> >s/ ati/radeon_chipset.h ---
> > xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_chipset.h	2004-08-12
> > 04:23:46.000000000 +0200
> > +++
> > src.xorg.1129808283.2035.3041395841/xc/programs/Xserver/hw/xfree86/driver
> >s/ ati/radeon_chipset.h 2005-10-20 19:58:39.000000000 +0200
> > @@ -1,4 +1,4 @@
> > -static SymTabRec RADEONChipsets[] = {
> > +SymTabRec RADEONChipsets[] = {
> >      { PCI_CHIP_RADEON_QD, "ATI Radeon QD (AGP)" },
> >      { PCI_CHIP_RADEON_QE, "ATI Radeon QE (AGP)" },
> >      { PCI_CHIP_RADEON_QF, "ATI Radeon QF (AGP)" },
> >
> > @Stefan: Is it possible to compile xorg with gcc 4.0.0 without that part?
>
> IIRC, no. I think that parts fixes the gcc40 error "static declaration of
> RADEONChipsets follows non-static declaration ..."
> Afaik gcc34 simply ignores the static specifier on the second declaration
> so the code _should_ build in exactly the same way with or without the
> patch. If not then probably both declarations should be static.

I just tested that xorg also compiles for a default crystal target if both 
declarations are static. Maybe you want to try this patch: 
https://www.rocklinux.net/submaster/smadm.cgi?i=2005111720270113740

With best regards,
	Stefan

> > Greetings,
> > 	Benjamin
>
> _______________________________________________
> rock-devel mailing list
> [email protected]
> http://www.rocklinux.net/mailman/listinfo/rock-devel