Re: [rock-sm] 2006010419093916663 blindcoder msg argh... now I see it again

On Mon, Jan 09, 2006 at 12:25:49PM +0100, [email protected] wrote:
> Open Patch: 2006010419093916663 [by fake]                        + fake
> 
> fake:
>         fix udev scsi script. this fixes almost all udev-related
>         bugs for me by reverting behaviour back to the way it
>         used to be. maybe it's not 1337, but it works.
> 
> (fake) and again, i forgot to increase $extraversion
> (blindcoder) either this patch is incomplete or untested. Have a
> look at package/base/udev/scsi_dev_discs_rules.patch
> (fake) i don't get what you mean - i don't touch the rules, just
> the scsi-devfs script: scsi_dev_discs.patch
> (blindcoder) nevermind. when writing the response I saw my
> mistake
> (blindcoder) argh... now I see it again

This part of your patch:

-+echo $l_phy $s_phy $l_log $s_log discs/disc${x}/${lpart}
++echo $l_log $s_log discs/disc${x}/${lpart}

conflicts with this part of scsi_dev_discs_rules.patch:

+BUS=="scsi", KERNEL=="sd*", PROGRAM="/etc/udev/scripts/scsi-devfs.sh sd %b %n", NAME="%c{1}", SYMLINK="%c{2} %k %c{3} %c{4} %c{5}"
+BUS=="scsi", KERNEL=="sr*", PROGRAM="/etc/udev/scripts/scsi-devfs.sh sr %b %n", NAME="%c{1}", SYMLINK="%c{2} %k %c{3} %c{4} %c{5}"
+BUS=="scsi", KERNEL=="st*", PROGRAM="/etc/udev/scripts/scsi-devfs.sh st %b %n", NAME="%c{1}", SYMLINK="%c{2} %k %c{3} %c{4} %c{5}"
+BUS=="scsi", KERNEL=="sg*", PROGRAM="/etc/udev/scripts/scsi-devfs.sh sg %b %n", NAME="%c{1}", SYMLINK="%c{2} %k %c{3} %c{4} %c{5}"

You only echo three things whereas the rules expect five.

Greetings,
	Benjamin
-- 
Go away, or I will replace you with a very small shellscript!
	http://shellscripts.org/

_______________________________________________
rock-devel mailing list
[email protected]
http://www.rocklinux.net/mailman/listinfo/rock-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFDwkl2r0OTeImXvg8RAt9hAJ9pKl7tsAKfHSWUOOM+qQdZgMv3XACfTXJ9
FO+uSbhCpNqjhfUEYYxCKsg=
=CMik
-----END PGP SIGNATURE-----