[PATCH net-next v7 00/15][pull request] Introduce iXD driver
Tony Nguyen <[email protected]> Mon, 3 Aug 2026 20:16:20 -0700
| Newsgroups | gmane.linux.documentation,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
Larysa Zaremba says: This patch series adds the iXD driver, which supports the Intel(R) Control Plane PCI Function on Intel E2100 and later IPUs and FNICs. It facilitates a centralized control over multiple IDPF PFs/VFs/SFs exposed by the same card. The reason for the separation is to be able to offload the control plane to the host different from where the data plane is running. This is the first phase in the release of this driver where we implement the initialization of the core PCI driver. Subsequent phases will implement advanced features like usage of idpf ethernet aux device, link management, NVM update via devlink, switchdev port representors, data and exception path, flow rule programming, etc. The first phase entails the following aspects: 1. Additional libie functionalities: Patches 1-5 introduce additional common library API for drivers to communicate with the control plane through mailbox communication. A control queue is a hardware interface which is used by the driver to interact with other subsystems (like firmware). The library APIs allow the driver to setup and configure the control queues to send and receive virtchnl messages. The library has an internal bookkeeping (XN API) mechanism to keep track of the send messages. It supports both synchronous as well as asynchronous way of handling the messages. The library also handles the timeout internally for synchronous messages using events. This reduces the driver's overhead in handling the timeout error cases. The current patch series supports only APIs that are needed for device initialization. These include APIs in the libie_pci module: * Allocating/freeing the DMA memory and mapping the MMIO regions for BAR0, read/write APIs for drivers to access the MMIO memory and libie_cp module: * Control queue initialization and configuration * Transport initialization for bookkeeping * Blocking and asynchronous mailbox transactions Once the mailbox is initialized, the drivers can send and receive virtchnl messages to/from the control plane. The modules above are not supposed to be linked with the main libie library, but do share the folder with it. 2. idpf: Patches 6-11 refactor the idpf driver to use the libie APIs for control queue configuration, virtchnl transaction, device initialization and reset and adjust related code accordingly. 3. ixd: Patches 12-15 add the ixd driver and implement multiple pieces of the initialization flow as follows: * Add the ability to load * A reset is issued to ensure a clean device state, followed by initialization of the mailbox * Device capabilities: As part of initialization, the driver has to determine what the device is capable of (ex. max queues, vports, etc). This information is obtained from the firmware and stored by the driver. * Enable initial support for the devlink interface --- v7: * alphabetize ixd entry in Ethernet driver docs (moved before ixgbe) * remove redundant bool mapped = false initialization (idpf) * remove unused adapter parameter from idpf_mb_clean() (idpf) * add idpf_send_mb_msg_stack() macro with static_assert() to enforce on-stack buffer size limits (idpf) * update kdocs for idpf_cfg_lan_memory_regions() and idpf_map_remaining_mmio_regs() * remove premature LIBETH Kconfig dependency (ixd) * remove untriggerable WARN_ON(ent->device != IXD_DEV_ID_CPF) check * switch from system_unbound_wq to system_dfl_wq * add error classification for retry logic: fail immediately on non-transient errors * use LARGEST_ALIGN() instead of hardcoded 4K alignment for descriptor ring * add !qinfo->len validation check, return -EINVAL for length errors * clear TX tail register in libie_ctlq_init_regs() per spec * clear DD bit after receiving messages, to reduce dependency on correct refills * add new libie_ctlq_send_clean() API and refactor xn cleanup * use dma_pool for small buffers instead of individual DMA allocations * store small DMA memory directly in xn entry (small_dma_mem) instead of separate allocation * use per-slot cookie increment instead of global counter * use kvzalloc_obj()/kvfree() for xn manager allocation (large) * add bar_idx bounds validation (< PCI_NUM_RESOURCES, >= 0) * add pci_resource_is_mem() check * improve libie kdoc * add WARN_ONCE() when accessing unmapped MMIO regions * move libie_cp_dma_mem.direction to an earlier commit * adjust commit messages v6: https://lore.kernel.org/netdev/[email protected]/ * use idpf_mmio_region_non_static() in idpf_idc_init_aux_core_dev() to avoid code duplication * change LIBIE_CTLQ_TYPE_TX/RX from macros to enum libie_ctlq_type * pull libie_ctlq_xn_shutdown() out of libie_ctlq_xn_deinit() for consistency and to avoid unlikely races with send queue force-cleaning * remove unused send_ctx field from struct libie_ctlq_xn_clean_params * add missing dma_wmb() before tail register update in libie_ctlq_post_rx_buffs() * initialize mem->direction in libie_cp_alloc_dma_mem (purely cosmetic) * remove unnecessary dma_mb() for coherent DMA in libie_ctlq_xn_send_clean() * removed redundant list-init check * fixed whitespaces not flagged by checkpatch * improved documentation v5: https://lore.kernel.org/netdev/[email protected]/ * Add length validation to libie_ctlq_add() * Add memory barrier before writing tail in libie_ctlq_send() * Reduce larger then needed size allocation in libie_ctlq_xn_init_dma() * Clarify error message on dev init failure in idpf_probe() * Nullify adapter->asq and adapter->arq on failure in idpf_init_dflt_mbx() * Correct virtchnl version compatibility checks in ixd_handle_vc_ver() * Misc documentation fixes v4: https://lore.kernel.org/netdev/[email protected]/ * use check_add_overflow() for MMIO offset+size bounds check in libie_pci * replace iounmap() with pci_iounmap() for MMIO regions in libie_pci * fix missing rx_buf->offset when constructing ctlq Rx message address * always zero Rx descriptor before reallocation * do not call complete() inside spinlock, theoretical use-after-free * reset async xn state to IDLE before freeing in libie_ctlq_xn_shutdown() * zero control queue Tx descriptor before freeing memory * remove unused ctx field from struct libie_ctlq_xn_clean_params * roll back merging of idpf_deinit_dflt_mbx() and xnm shutdown, those calls are separate again (so idpf refactoring becomes more trivial) * introduce idpf_send_vf_reset_msg() for one-way VF reset message bypassing XN manager, which is shut down by now * guard libie_ctlq_xn_shutdown() against NULL xnm in idpf_vc_event_task(), this is needed if reset fails and reschedules * validate response sizes in idpf more * fix MAINTAINERS glob pattern for include/linux/net/intel/ * roll back linux/{net/intel -> intel}/* change (1st patch) * use pci_iomap_range() to map regions in libie_pci * improve libie_pci commit message * remove broken dead code for getting RSS from idpf (new patch!) * use maximum alignment for control queue stack buffer in ixd * fix ixd_ctlq_clean_sq() usage * do not register ixd devlink prematurely * improve receive buffer size validation in idpf v3: https://lore.kernel.org/netdev/[email protected]/ - lock libie ctlq transaction earlier on Rx path - improve ctlq Rx buffer size validation both in idpf and libie - fix RSS LUT buf size (will also go to stable separately) - improve xnm shutdown handling - skip zero-sized BAR regions instread of returning error in idpf - unify treatment of initialized and uninitialized ctlq messages v2: https://lore.kernel.org/netdev/[email protected]/ - improved failure handling and input validation - removed cp version from devlink in ixd v1: https://lore.kernel.org/netdev/[email protected]/ The following are changes since commit d661abdc30c254649c32ef6e0aa1e621e04ff0a7: net: ngbe: correct misleading interrupt comment and are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 200GbE Amritha Nambiar (1): ixd: add devlink support Larysa Zaremba (6): idpf: remove unused code for getting RSS info from device idpf: make mbx_task queueing and cancelling more consistent idpf: print a debug message and bail in case of non-event ctlq message ixd: add basic driver framework for Intel(R) Control Plane Function ixd: add reset checks and initialize the mailbox ixd: add the core initialization Pavan Kumar Linga (4): libeth: allow to create fill queues without NAPI idpf: remove 'vport_params_reqd' field idpf: refactor idpf to use libie_pci APIs idpf: refactor idpf to use libie control queues Phani R Burra (3): libie: add PCI device initialization helpers to libie libie: add control queue support libie: add bookkeeping support for control queue messages Victor Raj (1): virtchnl: move virtchnl and virtchnl2 headers to 'include/linux/net/intel' .../device_drivers/ethernet/index.rst | 1 + .../device_drivers/ethernet/intel/ixd.rst | 39 + Documentation/networking/devlink/index.rst | 1 + Documentation/networking/devlink/ixd.rst | 30 + MAINTAINERS | 3 +- drivers/net/ethernet/intel/Kconfig | 2 + drivers/net/ethernet/intel/Makefile | 1 + drivers/net/ethernet/intel/i40e/i40e.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 +- .../net/ethernet/intel/i40e/i40e_prototype.h | 2 +- .../ethernet/intel/i40e/i40e_virtchnl_pf.h | 2 +- drivers/net/ethernet/intel/iavf/iavf.h | 2 +- drivers/net/ethernet/intel/iavf/iavf_common.c | 2 +- .../net/ethernet/intel/iavf/iavf_prototype.h | 3 +- drivers/net/ethernet/intel/iavf/iavf_types.h | 4 +- drivers/net/ethernet/intel/ice/ice.h | 2 +- drivers/net/ethernet/intel/ice/ice_common.h | 2 +- drivers/net/ethernet/intel/ice/ice_vf_lib.h | 2 +- .../net/ethernet/intel/ice/virt/virtchnl.h | 2 +- drivers/net/ethernet/intel/idpf/Kconfig | 1 + drivers/net/ethernet/intel/idpf/Makefile | 2 - drivers/net/ethernet/intel/idpf/idpf.h | 99 +- .../net/ethernet/intel/idpf/idpf_controlq.c | 621 ------ .../net/ethernet/intel/idpf/idpf_controlq.h | 144 -- .../ethernet/intel/idpf/idpf_controlq_api.h | 177 -- .../ethernet/intel/idpf/idpf_controlq_setup.c | 169 -- drivers/net/ethernet/intel/idpf/idpf_dev.c | 101 +- .../net/ethernet/intel/idpf/idpf_ethtool.c | 28 +- drivers/net/ethernet/intel/idpf/idpf_idc.c | 32 +- drivers/net/ethernet/intel/idpf/idpf_lib.c | 69 +- drivers/net/ethernet/intel/idpf/idpf_main.c | 115 +- drivers/net/ethernet/intel/idpf/idpf_mem.h | 20 - drivers/net/ethernet/intel/idpf/idpf_txrx.c | 4 +- drivers/net/ethernet/intel/idpf/idpf_txrx.h | 4 +- drivers/net/ethernet/intel/idpf/idpf_vf_dev.c | 96 +- .../net/ethernet/intel/idpf/idpf_virtchnl.c | 1879 +++++++---------- .../net/ethernet/intel/idpf/idpf_virtchnl.h | 127 +- .../ethernet/intel/idpf/idpf_virtchnl_ptp.c | 310 ++- drivers/net/ethernet/intel/ixd/Kconfig | 14 + drivers/net/ethernet/intel/ixd/Makefile | 13 + drivers/net/ethernet/intel/ixd/ixd.h | 59 + drivers/net/ethernet/intel/ixd/ixd_ctlq.c | 139 ++ drivers/net/ethernet/intel/ixd/ixd_ctlq.h | 34 + drivers/net/ethernet/intel/ixd/ixd_dev.c | 89 + drivers/net/ethernet/intel/ixd/ixd_devlink.c | 97 + drivers/net/ethernet/intel/ixd/ixd_devlink.h | 50 + drivers/net/ethernet/intel/ixd/ixd_lan_regs.h | 68 + drivers/net/ethernet/intel/ixd/ixd_lib.c | 180 ++ drivers/net/ethernet/intel/ixd/ixd_main.c | 144 ++ drivers/net/ethernet/intel/ixd/ixd_virtchnl.c | 190 ++ drivers/net/ethernet/intel/ixd/ixd_virtchnl.h | 12 + drivers/net/ethernet/intel/libeth/rx.c | 12 +- drivers/net/ethernet/intel/libie/Kconfig | 14 + drivers/net/ethernet/intel/libie/Makefile | 8 + drivers/net/ethernet/intel/libie/controlq.c | 1280 +++++++++++ drivers/net/ethernet/intel/libie/pci.c | 223 ++ include/linux/net/intel/libie/controlq.h | 434 ++++ include/linux/net/intel/libie/pci.h | 56 + include/linux/{avf => net/intel}/virtchnl.h | 0 .../linux/net/intel}/virtchnl2.h | 0 .../linux/net/intel}/virtchnl2_lan_desc.h | 0 include/net/libeth/rx.h | 4 +- 62 files changed, 4322 insertions(+), 2900 deletions(-) create mode 100644 Documentation/networking/device_drivers/ethernet/intel/ixd.rst create mode 100644 Documentation/networking/devlink/ixd.rst delete mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.c delete mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.h delete mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq_api.h delete mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq_setup.c delete mode 100644 drivers/net/ethernet/intel/idpf/idpf_mem.h create mode 100644 drivers/net/ethernet/intel/ixd/Kconfig create mode 100644 drivers/net/ethernet/intel/ixd/Makefile create mode 100644 drivers/net/ethernet/intel/ixd/ixd.h create mode 100644 drivers/net/ethernet/intel/ixd/ixd_ctlq.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_ctlq.h create mode 100644 drivers/net/ethernet/intel/ixd/ixd_dev.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.h create mode 100644 drivers/net/ethernet/intel/ixd/ixd_lan_regs.h create mode 100644 drivers/net/ethernet/intel/ixd/ixd_lib.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_main.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_virtchnl.c create mode 100644 drivers/net/ethernet/intel/ixd/ixd_virtchnl.h create mode 100644 drivers/net/ethernet/intel/libie/controlq.c create mode 100644 drivers/net/ethernet/intel/libie/pci.c create mode 100644 include/linux/net/intel/libie/controlq.h create mode 100644 include/linux/net/intel/libie/pci.h rename include/linux/{avf => net/intel}/virtchnl.h (100%) rename {drivers/net/ethernet/intel/idpf => include/linux/net/intel}/virtchnl2.h (100%) rename {drivers/net/ethernet/intel/idpf => include/linux/net/intel}/virtchnl2_lan_desc.h (100%) -- 2.47.1