Re: [PATCH v4 7/7] mm: Documentation: clarify where the mTHP stats live

On Tue, Aug 11, 2026 at 06:48:39AM -0600, Nico Pache (Red Hat) wrote:
> The note about khugepaged counters references /proc/vmstat for the PMD
> case, but never mentions where the mTHPs stats can be found
> (i.e.: /sys/kernel/mm/transparent_hugepage/hugepages-<size>kB/stats/)
> Add a small addition to this section for clarity.
>
> Also fix a missing period while we are at it.
>
> Reviewed-by: Baolin Wang <[email protected]>
> Suggested-by: Lorenzo Stoakes <[email protected]>
> Acked-by: David Hildenbrand (Arm) <[email protected]>
> Signed-off-by: Nico Pache (Red Hat) <[email protected]>

Thanks! LGTM so:

Reviewed-by: Lorenzo Stoakes (ARM) <[email protected]>


> ---
>  Documentation/admin-guide/mm/transhuge.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> index 16f37135ed80..b187d618452f 100644
> --- a/Documentation/admin-guide/mm/transhuge.rst
> +++ b/Documentation/admin-guide/mm/transhuge.rst
> @@ -224,7 +224,7 @@ khugepaged will be automatically started when any THP size is enabled
>  (either of the per-size anon control or the top-level control are set
>  to "always" or "madvise"), and it'll be automatically shutdown when
>  all THP sizes are disabled (when both the per-size anon control and the
> -top-level control are "never")
> +top-level control are "never").
>
>  process THP controls
>  --------------------
> @@ -301,7 +301,9 @@ being replaced by a PMD mapping, or (2) physical pages replaced by one
>  hugepage of various sizes (PMD-sized or mTHP). Each may happen independently,
>  or together, depending on the type of memory and the failures that occur.
>  As such, this value should be interpreted roughly as a sign of progress,
> -and counters in /proc/vmstat consulted for more accurate accounting)::
> +and counters in /proc/vmstat consulted for more accurate accounting.
> +Per-order mTHP collapse statistics are also available under
> +/sys/kernel/mm/transparent_hugepage/hugepages-<size>kB/stats/)::
>
>  	/sys/kernel/mm/transparent_hugepage/khugepaged/pages_collapsed
>
>
> --
> 2.55.0
>

--
Cheers, Lorenzo