Re: [PATCH net-next v3 0/7] netconsole: validate a target's IP address configuration

Jakub Kicinski <[email protected]>
Newsgroups gmane.linux.kernel,gmane.linux.network,gmane.linux.documentation
Message-ID <[email protected]>
On Fri, 14 Aug 2026 20:28:51 +0100 Gustavo Luiz Duarte wrote:
> This series adds two validations to the target configuration when the
> user tries to enable it: first whether remote_ip was set, and second
> whether local_ip and remote_ip address families match. Refuse to enable
> the target if any of those validations fail.
> 
> These validations are already done for the target passed on the
> command-line, so this aligns dynamic targets with the command-line
> behavior.
> 
> The first two patches replace the per-target 'ipv6' flag with a
> per-address 'family' field, which makes it easier to detect these error
> conditions. Patches 3 and 4 implement the actual validations.
> 
> Patches 5-7 are follow-ups from previous reviews: move inet_addr from
> netpoll.h into netconsole.c, show an unset address as an empty string
> rather than "0.0.0.0", document local_ip auto-selection.

LGTM, but feels to risky to merge during the merge window.
Since we're changing semantics we should let this sit in linux-next
for at least a week. Please repost in Sept.

BTW please carefully review clashiko feedback:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected]
It marked as preexisting the problem of IP versions diverging but 
I think it's relevant (patch 2)?
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.