RE: smartmontools

Hello...

	I tried this, it still broke :(


On Mon, 2003-06-16 at 06:40, Salyzyn, Mark wrote:
> As the message "office18 kernel: Unhandled SCSI Command: 0x4d" implies, it
> is an unhandled call. aacraid is a scsi->block FIB converter, so all SCSI
> commands are simulated/spoofed.
> 
> aacraid returns the unhandled Log Sense command with a check condition,
> stored with an Invalid command key in the sense information. I see something
> unbecoming in the return sequence, it returns with a -1 to the scsi queue
> layer, yet it completes the command appropriately (with error spoofed in
> scsi response) as if properly queued.
> 
> A possibility is that:
> 
>                 default:
>                         /*
>                          *      Unhandled commands
>                          */
>                         printk(KERN_WARNING "Unhandled SCSI Command:
> 0x%x.\n", scsicmd->cmnd[0]);
>                         scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE <<
> 8 | CHECK_CONDITION;
>                         set_sense((u8 *) &sense_data[cid],
>                                 SENKEY_ILLEGAL, SENCODE_INVALID_COMMAND,
>                         ASENCODE_INVALID_COMMAND, 0, 0, 0, 0);
>                         __aac_io_done(scsicmd);
>                         return -1;
> 
> Needs to have the `return -1;' replaced with a `return 0;' on line 1142 (in
> my version) of aachba.c.
> 
> Any chance you can check if this confirms resolution to this issue of
> locking up the kernel?
> 
> Sincerely -- Mark Salyzyn
> 
> -----Original Message-----
> From: Matt Domsch [mailto:[email protected]]
> Sent: Monday, June 16, 2003 9:21 AM
> To: [email protected]
> Subject: Fw: smartmontools
> 
> 
> Thought this discussion might be better targeted at linux-aacraid-devel.
> -Matt
-- 
Christopher McCrory
 "The guy that keeps the servers running"
 
[email protected]
 http://www.pricegrabber.com
 
Let's face it, there's no Hollow Earth, no robots, and
no 'mute rays.' And even if there were, waxed paper is
no defense.  I tried it.  Only tinfoil works.


_______________________________________________
Linux-aacraid-devel mailing list
[email protected]
http://lists.us.dell.com/mailman/listinfo/linux-aacraid-devel
Please read the FAQ at http://lists.us.dell.com/faq or search the list archives at http://lists.us.dell.com/htdig/