Re: XC4000: added card_type

On Fri, Jun 3, 2011 at 8:38 AM, [email protected] <[email protected]> wrote:
> This patch adds support for selecting a card type in struct
> xc4000_config, to allow for implementing some card specific code
> in the driver.
>
> Signed-off-by: Istvan Varga <[email protected]>

Hi Istan,

I understand what you're trying to do here, but this is not a good
approach.  We do not want to be littering tuner drivers with
card-specific if() statements.  Also, this is inconsistent with the
way all other tuner drivers work.

The approach you are attempting may seem easier at first, but it gets
very difficult to manage over time as the number of boards that use
the driver increases.

You should have the bridge driver be setting up the cfg structure and
passing it to the xc4000 driver, just like the xc5000 and xc3028 do.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead [email protected]
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb