Re: Interfaces to limit string sizes

Michal Čihař <[email protected]> Tue, 22 Mar 2016 09:13:58 +0100

Newsgroups	gmane.linux.drivers.gammu
Message-ID	<[email protected]>

Hi

Dne 21.3.2016 v 23:08 Paulo Roberto napsal(a):
> I've been using LibGammu in some projects, it's a great project.
> 
> But I noticed that dealing with strings could be a lot error prone and
> if not careful you could have some security issues.
> I say this because of the use of static string variables and the
> assumption of correctness in the buffer size.

Indeed it does. The buffer sizes are exported as well in gammu-limits.h.

> To solve it in my projects I implemented some new interfaces for the
> functions that I use. Mainly in coding.c and api.c.
> 
> The new functions do the same of the old ones, but add the control of
> limit buffers size. I was not sure about how to name the new functions,
> so I added a '_s' in the name of the old functions.
> 
> Example:
>    CopyUnicodeString => CopyUnicodeString_s
> 
> I'm sending a little patch with these changes. If you approve the
> modification, I would be glad to add equivalent functions for the rest
> of the API when it requires.

I'm not really sure if it's good idea to add second set of API,
especially as your changes basically duplicate existing code, what will
make it really easy to fix only one copy of it in future...

-- 
	Michal Čihař | http://cihar.com/ | https://weblate.org/

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

_______________________________________________
Gammu-users mailing list - https://lists.sourceforge.net/lists/listinfo/gammu-users

signature.asc (application/pgp-signature, 819 B)