Re: [1/2]: Patch smsd/sqlite: Several bug fixes / optimizations

Daniele Forsi <[email protected]>
Newsgroups gmane.linux.drivers.gnokii
Message-ID <CAN_we7MS2NVvH-YOL361e4JXz1_qtv_midxwVcpfj5xFj1sqSg@mail.gmail.com>
2013/3/23 Pedro Aguilar:

> This patch skips the sleep(1) when there was no error in WriteSMS().

I'll let Jan speak for this, but I wouldn't aplly this patch for two reasons:

the line you added has tabs instead of spaces, just use what the
surrounding lines use

the check for the error variable in while() will always be true now
since you break on the negated condition so you can use just
while (numError++ < 3);

-- 
Daniele Forsi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.