Re: [PATCH 3/8] Remove some unnecessary #ifndef WIN32
Pawel Kot <[email protected]> Mon, 3 Dec 2018 20:18:12 +0300
| Newsgroups | gmane.linux.drivers.gnokii |
|---|---|
| Message-ID | <CAHytCw7ZfDNHC0bZOZ1sJ=bUuY1SfH9bHXLD16CWNMWa6UnbdQ@mail.gmail.com> |
--===============7329481553563518405== Content-Type: multipart/alternative; boundary="0000000000001830db057c2156ac" --0000000000001830db057c2156ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Mon, Dec 3, 2018 at 7:49 PM Ladislav Michl <[email protected]> wrote: > > Hi Pawe=C5=82, > > On Mon, Dec 03, 2018 at 06:15:07PM +0300, Pawel Kot wrote: > > Hi, > > > > On Mon, Dec 3, 2018 at 12:41 PM Ladislav Michl <[email protected]> wrote: > > > diff --git a/gnokii/gnokii-calendar.c b/gnokii/gnokii-calendar.c > > > index e32bf769..10236bae 100644 > > > --- a/gnokii/gnokii-calendar.c > > > +++ b/gnokii/gnokii-calendar.c > > > @@ -264,7 +264,6 @@ gn_error writecalendarnote(int argc, char *argv[]= , > > gn_data *data, struct gn_stat > > > -#ifndef WIN32 > > > if (error =3D=3D GN_ERR_NOTIMPLEMENTED) { > > > switch (gn_vcal_file_event_read(optarg, &calnote, > > i)) { > > > > Probably excluding it for all WIN32 platforms is excessive, but > > gn_vcal_file_event_read() is generated by flex, which is missing on native > > Windows platforms. I'm fine with changing it but it will fail on Visual > > Studio platforms. > > Which leads to a question whenever flex output should be part of source > tarball. Developers working on git version should be smart enough to setu= p > their envinroment properly. Yes, we had this discussion some time ago. The conclusion was that in git tree we do not keep it, but we put it into a source tarball. Still, I'm not sure if it would compile under Windows. Cheers, Pawe=C5=82 -- Pawel Kot --0000000000001830db057c2156ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi,<br><br>On Mon, Dec 3, 2018 at 7:49 PM Ladislav Michl &= lt;<a href=3D"mailto:[email protected]">[email protected]</a>> wro= te:<br>><br>> Hi Pawe=C5=82,<br>><br>> On Mon, Dec 03, 2018 at = 06:15:07PM +0300, Pawel Kot wrote:<br>> > Hi,<br>> ><br>> &g= t; On Mon, Dec 3, 2018 at 12:41 PM Ladislav Michl <<a href=3D"mailto:lad= [email protected]">[email protected]</a>> wrote:<br>> > > di= ff --git a/gnokii/gnokii-calendar.c b/gnokii/gnokii-calendar.c<br>> >= > index e32bf769..10236bae 100644<br>> > > --- a/gnokii/gnokii= -calendar.c<br>> > > +++ b/gnokii/gnokii-calendar.c<br>> > &= gt; @@ -264,7 +264,6 @@ gn_error writecalendarnote(int argc, char *argv[],<= br>> > gn_data *data, struct gn_stat<br>> > > -#ifndef WIN32= <br>> > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = if (error =3D=3D GN_ERR_NOTIMPLEMENTED) {<br>> > > =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 switc= h (gn_vcal_file_event_read(optarg, &calnote,<br>> > i)) {<br>>= ><br>> > Probably excluding it for all WIN32 platforms is excessi= ve, but<br>> > gn_vcal_file_event_read() is generated by flex, which = is missing on native<br>> > Windows platforms. I'm fine with chan= ging it but it will fail on Visual<br>> > Studio platforms.<br>><b= r>> Which leads to a question whenever flex output should be part of sou= rce<br>> tarball. Developers working on git version should be smart enou= gh to setup<br>> their envinroment properly.<br><br>Yes, we had this dis= cussion some time ago. The conclusion=C2=A0was that in git tree we do not k= eep it, but we put it into a source tarball. Still, I'm not sure if it = would compile under Windows.<br><br>Cheers,<div>Pawe=C5=82<br>--<br>Pawel K= ot<br></div></div> --0000000000001830db057c2156ac-- --===============7329481553563518405== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ gnokii-users mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/gnokii-users --===============7329481553563518405==--