Re: [PATCH 2/8] Use lower case for Win32 includes
Fabrizio Gennari <[email protected]> Mon, 3 Dec 2018 22:35:22 +0100
| Newsgroups | gmane.linux.drivers.gnokii |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============0796862983810319543== Content-Type: multipart/alternative; boundary="------------EEF742D21BB6DFD24F8022C5" Content-Language: en-US This is a multi-part message in MIME format. --------------EEF742D21BB6DFD24F8022C5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Il 03-12-18 16:10, Pawel Kot ha scritto: > Hi, > > On Mon, Dec 3, 2018 at 12:42 PM Ladislav Michl <[email protected] > <mailto:[email protected]>> wrote: > > diff --git a/include/gnokii.h.in <http://gnokii.h.in> > b/include/gnokii.h.in <http://gnokii.h.in> > > index b3253455..d407d53d 100644 > > --- a/include/gnokii.h.in <http://gnokii.h.in> > > +++ b/include/gnokii.h.in <http://gnokii.h.in> > > @@ -31,8 +31,8 @@ extern "C" { > [...] > > -#elif defined(_MSC_VER) && defined(WIN32) > [...] > > +#elif defined(WIN32) > > So this one changes behaviour and is not explained. And not sure if > correct. Care to give an explanation? This fixes a compilation error on MinGW32 about struct timeval not being defined i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -g -O2 -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing -MT dump_vcard-dump-vcard.o -MD -MP -MF .deps/dump_vcard-dump-vcard.Tpo -c -o dump_vcard-dump-vcard.o `test -f 'dump-vcard.c' || echo './'`dump-vcard.c In file included from ../include/gnokii.h:63:0, from dump-vcard.c:4: ../include/gnokii/common.h:775:17: error: field ‘last’ has incomplete type struct timeval last; ^~~~ In file included from ../include/gnokii/data.h:22:0, from ../include/gnokii.h:64, from dump-vcard.c:4: ../include/gnokii/call.h:70:17: error: field ‘start_time’ has incomplete type struct timeval start_time; ^~~~~~~~~~ ../include/gnokii/call.h:71:17: error: field ‘answer_time’ has incomplete type struct timeval answer_time; ^~~~~~~~~~~ --------------EEF742D21BB6DFD24F8022C5 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <p><br> </p> <div class="moz-cite-prefix">Il 03-12-18 16:10, Pawel Kot ha scritto:<br> </div> <blockquote type="cite" cite="mid:CAHytCw6YcvknnrF7YPeNgkQ3GWq9y+_i8xZ2Z0YnzQ+FMjQgxg@mail.gmail.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <div dir="ltr">Hi,<br> <br> On Mon, Dec 3, 2018 at 12:42 PM Ladislav Michl <<a href="mailto:[email protected]" moz-do-not-send="true">[email protected]</a>> wrote:<br> > diff --git a/include/<a href="http://gnokii.h.in" moz-do-not-send="true">gnokii.h.in</a> b/include/<a href="http://gnokii.h.in" moz-do-not-send="true">gnokii.h.in</a><br> > index b3253455..d407d53d 100644<br> > --- a/include/<a href="http://gnokii.h.in" moz-do-not-send="true">gnokii.h.in</a><br> > +++ b/include/<a href="http://gnokii.h.in" moz-do-not-send="true">gnokii.h.in</a><br> > @@ -31,8 +31,8 @@ extern "C" { <div>[...]<br> > -#elif defined(_MSC_VER) && defined(WIN32)</div> <div>[...]<br> > +#elif defined(WIN32)<br> <br> So this one changes behaviour and is not explained. And not sure if correct. Care to give an explanation?</div> </div> </blockquote> <p>This fixes a compilation error on MinGW32 about struct timeval not being defined</p> <p>i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -g -O2 -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing -MT dump_vcard-dump-vcard.o -MD -MP -MF .deps/dump_vcard-dump-vcard.Tpo -c -o dump_vcard-dump-vcard.o `test -f 'dump-vcard.c' || echo './'`dump-vcard.c<br> In file included from ../include/gnokii.h:63:0,<br> from dump-vcard.c:4:<br> ../include/gnokii/common.h:775:17: error: field ‘last’ has incomplete type<br> struct timeval last;<br> ^~~~<br> In file included from ../include/gnokii/data.h:22:0,<br> from ../include/gnokii.h:64,<br> from dump-vcard.c:4:<br> ../include/gnokii/call.h:70:17: error: field ‘start_time’ has incomplete type<br> struct timeval start_time;<br> ^~~~~~~~~~<br> ../include/gnokii/call.h:71:17: error: field ‘answer_time’ has incomplete type<br> struct timeval answer_time;<br> ^~~~~~~~~~~<br> <br> </p> </body> </html> --------------EEF742D21BB6DFD24F8022C5-- --===============0796862983810319543== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ gnokii-users mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/gnokii-users --===============0796862983810319543==--