devices: pass gn_config to open and following devices: *: use instance data commits
Pawel Kot <[email protected]> Sun, 9 Jan 2022 19:55:40 +0100
| Newsgroups | gmane.linux.drivers.gnokii |
|---|---|
| Message-ID | <CAHytCw4AoXLkv43s1OFq0r2HerCS5XaEwqcn36ZvGcZhPZ8n6A@mail.gmail.com> |
--===============2442300656896467257== Content-Type: multipart/alternative; boundary="000000000000e4d09105d52ac6dc" --000000000000e4d09105d52ac6dc Content-Type: text/plain; charset="UTF-8" Hi Ladis, I'm in the process of pulling patches from you to the mainline. I think I got most of them already read, understood, and committed (will push them to my GitHub repo any time soon - will need to figure out how to push them to the official repo easily). However, a couple of questions popped up (raising them in separate emails). I can see that you are getting rid of gn_statemachine as a parameter to device drivers. What is the reason for this? I think we have this rather convenient and universal method of passing gn_statemachine as a context (agree that device drivers interface could be simplified though). Also, why do you move logic between usbfbus_find_interfaces() and fbusdku2sub_open()? Cheers, -- Pawel Kot --000000000000e4d09105d52ac6dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi Ladis,<div><br></div><div>I'm in the process of pul= ling patches from you to the mainline. I think I got most of them already r= ead, understood, and committed=C2=A0(will push them to my GitHub repo any t= ime soon - will need to figure out how to push them to the official repo ea= sily). However, a couple of questions popped up (raising them in separate e= mails).</div><div><br></div><div>I can see that you are getting rid of gn_s= tatemachine as a parameter to device drivers. What is the reason for this? = I think we have this rather convenient=C2=A0and universal method of passing= gn_statemachine as a context (agree that device drivers interface could be= simplified though).</div><div><br></div><div>Also, why do you move logic b= etween usbfbus_find_interfaces() and fbusdku2sub_open()?</div><div><br></di= v><div>Cheers,<br></div><div>-- <br><div dir=3D"ltr" class=3D"gmail_signatu= re" data-smartmail=3D"gmail_signature">Pawel Kot</div></div></div> --000000000000e4d09105d52ac6dc-- --===============2442300656896467257== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ gnokii-users mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/gnokii-users --===============2442300656896467257==--