Re: [PATCH] check for FT support when selecting FT suites

Ah you're right, my mistake, I'll resend.

On Mon, Feb 3, 2020 at 4:58 PM Brian Norris <[email protected]> wrote:
>
> On Mon, Feb 3, 2020 at 4:33 PM Matthew Wang <[email protected]> wrote:
> > A driver supports FT if it either supports SME or the
> > NL80211_CMD_UPDATE_FT_IES command. When selecting AKM suites,
> > wpa_supplicant currently doesn't take into account whether or not either
> > of those conditions are met. This can cause association failures e.g. when
> > an AP supports both WPA-EAP and FT-EAP but the driver doesn't support FT
> > (supplicant will decide to do FT-EAP since it is unaware the driver
> > doesn't support it). This change allows an FT suite to be selected only
> > when the driver also supports FT.
> >
> > Signed-off-by: Matthew Wang <[email protected]>
> > ---
>
> > diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> > index 9bdf88011..601b3e24c 100644
> > --- a/src/drivers/driver.h
> > +++ b/src/drivers/driver.h
> > @@ -1823,6 +1823,8 @@ struct wpa_driver_capa {
> >  #define WPA_DRIVER_FLAGS_CONTROL_PORT          0x0400000000000000ULL
> >  /** Driver supports VLAN offload */
> >  #define WPA_DRIVER_FLAGS_VLAN_OFFLOAD          0x0800000000000000ULL
> > +/** Driver supports UPDATE_FT_IES command */
> > +#define WPA_DRIVER_FLAGS_UPDATE_FT_IES         0x2000000000000000ULL
>
> Wouldn't the next available bit start with 0x1, not 0x2?
>
> Otherwise, looks good to me:
>
> Reviewed-by: Brian Norris <[email protected]>