Re: [Patch v9 06/16] nl80211: Migrate from set_tx to key_flag API

Am 04.01.20 um 23:10 schrieb Alexander Wetzel:
> Stop using set_tx and cleanup/restructure the key install logic.
> 
> Group/broadcast default keys are needing an additional netlink call
> (NL80211_CMD_SET_KEY) after the key has been installed.
> The nl80211 driver used a overly complex and not always correct method -
> involving also set_tx - to decide if the additional netlink call was
> needed.
> 
> Signed-off-by: Alexander Wetzel <[email protected]>

Not sure if you wait for a new patch to switch nl80211 over to key_flag 
or it's still in you active queue:

If it's in the queue:
With PTK0 merged I'll send you an updated version soon. (I hope this 
week.) It's basically ready and mostly cosmetic compared to V9. But I've 
added a optional second patch to replace WPA_ALG_PMK with KEY_FLAG_PMK, 
further sanitizing the APIs in my opinion.

And for the record:
The other Extended Key ID patches from v9 are seriously outdated and 
deprecated.

The not yet published V10 is handling some important things differently 
and (tries to) mitigate compatibility issues better. It only needs some 
polishing once nl80211 is switched over to key_flag and is already doing 
all what I plan to do in the version.

Alexander