RE: [PATCH 07/14] AP: Rename SAE anti clogging variables and functions

> -----Original Message-----
> From: Jouni Malinen <[email protected]>
> Sent: Tuesday, February 25, 2020 13:21
> To: Peer, Ilan <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH 07/14] AP: Rename SAE anti clogging variables and
> functions
> 
> On Mon, Feb 24, 2020 at 11:15:55AM +0200, Ilan Peer wrote:
> > PASN authentication mandates support for comeback flow, which among
> > others can be used for anti-clogging purposes.
> >
> > As the SAE support for anti clogging can also be used for PASN, start
> > modifying the source code so the anti clogging support can be used for
> > both SAE and PASN.
> >
> > As a start, rename some variables/functions etc. so that they would
> > not be SAE specific.
> 
> Why would these need to be renamed? Sure, it might be cleaner, but this
> results in changes that do not need strictly speaking required and also to
> changes that are problematic. Using
> 
> > diff --git a/hostapd/config_file.c b/hostapd/config_file.c @@ -4198,8
> > +4198,8 @@ static int hostapd_config_fill(struct hostapd_config *conf,
> > -	} else if (os_strcmp(buf, "sae_anti_clogging_threshold") == 0) {
> > -		bss->sae_anti_clogging_threshold = atoi(pos);
> > +	} else if (os_strcmp(buf, "anti_clogging_threshold") == 0) {
> > +		bss->anti_clogging_threshold = atoi(pos);
> 
> For example, this change of a configuration parameter name would break all
> existing deployments when they update hostapd. That does not look
> acceptable.
> 

My bad.

I would still prefer to have the renaming of internal functions etc. if possible and only leave the external API unchanged. If you think otherwise, I can drop this patch and align the following patches. Let me know what you prefer.

Thanks for taking a look at the patches,

Ilan.