Re: [PATCH 03/12] nl80211: Allow off-channel of authentication frames in send_mlme()

On Mon, Feb 24, 2020 at 11:14:28AM +0200, Ilan Peer wrote:
> As part of the support needed for PASN.

> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> @@ -3737,6 +3737,14 @@ static int wpa_driver_nl80211_send_mlme(struct i802_bss *bss, const u8 *data,
>  		   MAC2STR(mgmt->da), noack, freq, no_cck, offchanok, wait_time,
>  		   no_encrypt, fc, fc2str(fc), drv->nlmode);
>  
> +	if (is_sta_interface(drv->nlmode) &&
> +	    WLAN_FC_GET_TYPE(fc) == WLAN_FC_TYPE_MGMT &&
> +	    WLAN_FC_GET_STYPE(fc) == WLAN_FC_STYPE_AUTH) {
> +		return nl80211_send_frame_cmd(bss, freq, wait_time,
> +					      data, data_len, use_cookie, 1, noack,
> +					      1, csa_offs, csa_offs_len);
> +	}

Why would this ignore the no_cck and offchanok arguments from the caller
and replace these with hardcoded 1?

This seems to break SAE external authentication which needs the code
below to update freq from 0 to nl80211_get_assoc_freq() for the almost
identical nl80211_send_frame_cmd() call at the end of the function.

Why exactly is this change needed? Isn't the call at the end of the
function doing practically same for SAE Authentication frames without
breaking external authentication or ignoring no_cck/offchanok from the
caller?

-- 
Jouni Malinen                                            PGP id EFC895FA