Re: [PATCH 02/14] PASN: Add functions to compute PTK, MIC and hash

On Mon, Feb 24, 2020 at 11:15:17AM +0200, Ilan Peer wrote:
> 1. Add a function to derive the PTK from a PMK and additional data.
> 2. Add a function to calculate the MIC for a PASN frames.
> 3. Add a function to compute the hash of an authentication frame body.
> 
> The above are built only in case that CONFIG_PASN is enabled in build
> time.

> diff --git a/src/common/defs.h b/src/common/defs.h
> @@ -59,6 +59,12 @@ typedef enum { FALSE = 0, TRUE = 1 } Boolean;
> +#ifdef CONFIG_PASN
> +/* TODO: PASN AKM is not yet defined in the spec. */
> +#define WPA_KEY_MGMT_PASN BIT(25)
> +#endif /* CONFIG_PASN */

This WPA_KEY_MGMT_* bitmap is implementation specific and that itself
would not be much of an issue to extend, but the PASN AKM suite selector
itself is waiting for ANA assignment and as such, does not look ready to
be applied yet. Similarly, I'm not yet convinced that the crypto design
is yet finalized, so this patch as whole looks a bit too early at this
point in time.

-- 
Jouni Malinen                                            PGP id EFC895FA