RE: [PATCH 07/14] AP: Rename SAE anti clogging variables and functions

> -----Original Message-----
> From: Jouni Malinen <[email protected]>
> Sent: Sunday, March 01, 2020 00:32
> To: Peer, Ilan <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH 07/14] AP: Rename SAE anti clogging variables and
> functions
> 
> On Tue, Feb 25, 2020 at 12:10:39PM +0000, Peer, Ilan wrote:
> > I would still prefer to have the renaming of internal functions etc. if
> possible and only leave the external API unchanged. If you think otherwise, I
> can drop this patch and align the following patches. Let me know what you
> prefer.
> 
> That might be fine. However, are you sure that these values will be shared
> for both SAE and PASN? Is there any case where the same STA might be
> using both SAE and PASN in parallel? Could that result into any unexpected
> behavior if there is only one set of anti-clogging parameters and state?
> 

I cannot really guarantee that such a thing would be adequately implemented
by stations. As the anti-clogging token indexing  is based on the station address
I can extend comeback_token_hash() to concatenate the authentication algorithm
ID with the address, to allow concurrent support for SAE and PASN. What do you think?

Regards,

Ilan.