Re: [PATCH] ACS: cover not-offloaded-ACS with hw_mode=any
Neo Jou <[email protected]>
| Newsgroups | gmane.linux.drivers.hostap |
|---|---|
| Message-ID | <CAHNYD=smNMwPTG1ytfHju-2VHQQhhL4aReZEMV3JRX0je__iOw@mail.gmail.com> |
The cleanup and fixes are better than that I wrote at the first. Learn from this and thanks for kind guidance. BR, Neo Jou Jouni Malinen <[email protected]> > > On Mon, Jan 13, 2020 at 04:31:28PM +0800, [email protected] wrote: > > This patch is to extend the existing hw_mode=any to cover > > the not-offloaded-ACS case. > > > > We DONOT duplicate for the mode HOSTAPD_MODE_IEEE80211ANY in > > wpa_driver_nl80211_postprocess_modes(), so hostapd_select_hw_mode() > > cannot find suitable hw_mode and iface->current_mode is NULL. Thus, > > ACS code combine channels from multiple hw_mode lists, to determine > > which channel needs to be surveyed. Thus, there are some patches in > > src/ap/acs.c to handle the case that iface->current_mode is NULL, > > and to combine channels. > > > > Also in hostapd_is_usable_chans() called by hostapd_check_chans(), > > it updates the hw_mode, based on the frequency channel ACS picked. > > > > By this way, "hw_mode=any" can be used for not-offloaded-ACS case. > > Thanks, applied with some cleanup and fixes. > > -- > Jouni Malinen PGP id EFC895FA