Re: [PATCH v2 3/3] tests: Extended Key ID tests

On Fri, Mar 20, 2020 at 08:04:33PM +0100, Alexander Wetzel wrote:
> Add the needed infrastructure for the Extended Key ID tests, update
> tests overriding RSN Capabilities to work with and without Extended Key
> ID support and add additional interoperability tests for Extended Key
> ID.
> 
> All tests will use Extended Key ID by default when available.
> When Extended Key ID is not supported only ap_wpa2_ptk_extended_key_id
> will fail and all other tests for Extended Key ID will be skipped.

This is not the style I'd like to see in hwsim test cases. The test
cases should continue with the current default behavior, i.e., with
Extended Key ID use disabled by default, to maintain existing testing
coverage. New test cases could then be added to verify Extended Key ID
behavior. In other words, a single execution round should cover both
not-in-use and in-use cases to sufficient level of detail. For most test
cases, there is not really any difference, so the current test
configuration is fine and the new test cases would need to only cover
the cases where there is different behavior from use of Extended Key ID,
i.e., mainly the test cases that verify PTK rekeying and potentially
some protocol test cases to check unexpected behavior.

-- 
Jouni Malinen                                            PGP id EFC895FA