Re: [PATCH v2 3/3] tests: Extended Key ID tests

Am 23.03.20 um 11:31 schrieb Jouni Malinen:
> On Mon, Mar 23, 2020 at 01:02:47AM +0200, Jouni Malinen wrote:
>> For example, I'm using the following test cases to verify functionality
>> now. I probably broke something in the AP and/or STA changes because the
>> connection does not really work after key configuration, so need to
>> figure that one out, but at least these versions should show what I'm
>> looking for. I'll try to take a closer look at what was broken tomorrow.
>> The exact version of my pending branch is pushed to hostap.git as well,
>> should anyone else be interested in checking this.
> 
> OK, I found and fixed couple of issues and things seem to be working
> fine and not causing regressions even if some small details for
> Extended Key ID enabled cases might have been missed. I applied the
> updated versions of the patches 1 and 2 and my test cases for this. As
> far as patch 3 is concerned, I did not try to pull in changes from
> there. Additional test cases can be introduced separately on top of the
> current hostap.git snapshot as needed.
> 

Thanks, especially for the simplifications I missed.
Generally the changes make sense, but there are some which look wrong 
for me. I'll verify that and send you patches for the things where I 
believe you broke something and we discuss it case by case, ok?

That will probably span some days due to the limited time I can spend on 
that at the moment.
When that has been sorted out I'll see if there are some interesting 
tests for Extended Key ID worth to add.

Alexander