Re: [PATCH v2 11/11] nl80211: disable ctrl port over nl80211 for ap mode

On 4/18/20 7:57 PM, Jouni Malinen wrote:
> On Sat, Apr 11, 2020 at 12:25:27PM +0200, Markus Theil wrote:
>> AP mode under Linux currently checks the tx status of control port frames
>> over auxiliary socket data. As this is currently not possible for control
>> port over nl80211, disable AP mode over nl80211 control port for now.
>>
>> Code for AP mode is working besides this missing fast retransmit feature.
> Hmm.. We have already enabled EAPOL TX over control port in hostapd for
> TX..
I know, unfortunately I was not aware of this issue when sending the TX
path patches.
>> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
>> @@ -463,6 +463,7 @@ int send_and_recv_msgs_as_owner(struct wpa_driver_nl80211_data *drv,
>>  	 * has the connection owner property set in the kernel.
>>  	 */
>>  	if (drv->capa.flags & WPA_DRIVER_FLAGS_CONTROL_PORT &&
>> +	    !(drv->hostapd || drv->start_mode_ap) &&
>>  	    handle && set_owner)
>>  		if (nla_put_flag(msg, NL80211_ATTR_CONTROL_PORT_OVER_NL80211) ||
>>  		    nla_put_flag(msg, NL80211_ATTR_SOCKET_OWNER) ||
> And isn't this disabling this for RX, not TX?
>
> Is there a reason to disable this for RX in AP mode? The commit message
> is describing missing capability for TX, not RX..
You're right. It should disable TX not RX. I'll send an updated series.