Re: [PATCH v2 04/11] nl80211: rename nl_connect to nl_connect_and_ctrl

On Sat, Apr 11, 2020 at 12:25:20PM +0200, Markus Theil wrote:
> This patch is another preparation for rx over nl80211 control port.
> Besides the already used SOCKET_OWNER marking on interfaces, ctrl-port
> rx also sets a SOCKET_OWNER flag on the actual connect/associate or
> start AP. Afterwards, some operations can only be performed over the
> socket which set the owner flag initially.


>  src/drivers/driver_nl80211.c | 52 ++++++++++++++++++------------------
>  src/drivers/driver_nl80211.h |  2 +-

>  static int nl80211_init_connect_handle(struct i802_bss *bss)
>  {
> -	if (bss->nl_connect) {
> +	if (bss->nl_connect_or_ctrl) {
...

This does not look helpful or necessary to me. In fact, that "or_ctrl"
part seems to make this more confusing.. For me, this nl_connect is the
nk_sock that is used for operations related to connections. I'll drop
this patch from the series.

-- 
Jouni Malinen                                            PGP id EFC895FA