Re: [PATCH] nl80211: fix small room for AKM suites log splat

Stefan Lippers-Hollmann <[email protected]> Tue, 12 May 2020 05:33:26 +0200
Newsgroups gmane.linux.drivers.hostap
Message-ID <20200512053326.10171a25@mir>
Hi

On 2020-05-11, Petr Štetiar wrote:
> Commit dd74ddd0dff6 ("nl80211: Handle AKM suite selectors for AP
> configuration") added warning log message "nl80211: Not enough room for
> all AKM suites (num_suites=X > NL80211_MAX_NR_AKM_SUITES)" which in some
> cases fills logs every 3 seconds, so fix this by increasing the log
> message level to debug.
> 
> Reported-by: Stefan Lippers-Hollmann <[email protected]>
> Ref: https://patchwork.ozlabs.org/project/openwrt/patch/[email protected]/#2429246
[...]

Tested-by: Stefan Lippers-Hollmann <[email protected]>

As already quickly indicated on IRC, hostapd has been functional 
despite this regular warning, it merely made the system log ring buffer 
overflow with 'meaningless' (at least unfixable) warnings.

I've now successfully tested this patch on ipq40xx/ map-ac2200 
(ipq4019+qca9886, ath10k), using r13213-146e18af56 as a base (upgrading
locally to kernel v5.4.40, no code changes necessary to build on ath79, 
ath79-tiny, ipq40xx, ipq806x, lantiq; runtime tested on ipq40xx only so 
far) and Hauke's mac80211 v5.7-rc3 patchset. I don't really notice any
CPU load increase either (which might have been possible due to spinning
into the error case on a regular base, despite not actually printing out
the warning anymore), so this patch seems to work.

Regards, thanks
	Stefan Lippers-Hollmann

_______________________________________________
Hostap mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/hostap