Re: [PATCH 9/9] wpa_supplicant: Disable HT/VHT overrides in 6 GHz

On Fri, Apr 24, 2020 at 03:45:42PM -0700, Rajkumar Manoharan wrote:
> Do not allow HT and VHT overrides in 6 GHz band and disable both.

Why would wpa_supplicant need to do this? This patch is not really
"disabling overrides", but it is overriding HT and VHT to be disabled..
It does not sound appropriate to expect user space components to do
that. Wouldn't the kernel implementation need to handle this just like
it does handle HT/VHT/HE negotiation in general?

> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
> @@ -5195,6 +5195,11 @@ void wpa_supplicant_apply_ht_overrides(
>  	if (!ssid)
>  		return;
>  
> +	if (is_6ghz_freq(params->freq.freq)) {
> +		params->disable_ht = 1;
> +		return;
> +	}

I guess it might be fine to return here without setting disable_ht since
the rest of the function does not really apply for 6 GHz cases. However,
I'm not convinced this really has any point in existing in
wpa_supplicant. What is so special about 6 GHz that it would justify
this? It is not like we do this for the 2.4 GHz channel 14 (which does
not allow HT) or as far as VHT capabilities are concerned, for any of
the 2.4 GHz channels.

-- 
Jouni Malinen                                            PGP id EFC895FA