Re: [PATCH 6/6] nl80211: add ack handler for extack cookies

On Thu, 2020-05-28 at 10:46 +0200, Markus Theil wrote:
> This patch adds the actual extack cookie handler, which is now
> used by tx control port. If these cookies are not supported by
> the current kernel, a value of 0 is returned.

Huh. I'm surprised this wasn't there, I used this feature before :)

But I think you should reorder these patches. Put 5 and 6 first, it's
pure infrastructure.

> @@ -5322,7 +5362,11 @@ static int nl80211_tx_control_port(void *priv, const u8 *dest,
>  		return -ENOBUFS;
>  	}
>  
> -	ret = send_and_recv_msgs(bss->drv, msg, NULL, NULL, NULL, NULL);
> +	memset(&ext_arg, 0, sizeof(struct nl80211_ack_ext_arg));
> +	ext_arg.ext_data = &cookie;
> +	ret = send_and_recv_msgs(bss->drv, msg,
> +				 NULL, NULL,
> +				 ack_handler_cookie, &ext_arg);

And then roll this bit into a separate patch to use it for the control
port TX? Or maybe with the status handler, since it's only relevant
there?

johannes