Re: [hpoj-announce] Announce: hplip-0.8.2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 7 Dec 2004 11:18 am, Cory Meisch wrote:
> Hewlett-Packard is proud to announce the introduction of HP Linux
> Imaging and Printing System (HPLIP). HPLIP is a complete single and
> multi-function printing device connectivity solution for users of Linux
> OS. The goal of this project is to provide “radically simple” printing,
> scanning, photo card access, and device management to the consumer and
> business Linux user.

Cory,

Thanks for this long awaited release.

A couple of issues from a Debian GNU/Linux perspective.

. When following the Debian Installation instructions to the letter the
update-rc.d command fails with the following:

[...]
update-rc.d: error: expected runlevel [0-9S] (did you forget "." ?)
usage: update-rc.d [-n] [-f] <basename> remove
       update-rc.d [-n] <basename> defaults [NN | sNN kNN]
       update-rc.d [-n] <basename> start|stop NN runlvl [runlvl] [...] .
                -n: not really
                -f: force


. In trying to generate a Debian package for hplip (I'm currently the Debian
maintainer for hpoj) DESTDIR is not honoured for the following installation
candidates:

error: /usr/lib/python2.3/site-packages/cupsext.so: Permission denied
 /usr/bin/install -c -m 644
xml/errors.xml /home/msp/src/hpinkjet.sf.net/hplip-0.8.2/debian/hplip/usr/home/msp/src/hpinkjet.sf.net/hplip-0.8.2/debian/hplip/usr/hplip/data/xml/errors.xml
error.png
error: /usr/lib/python2.3/site-packages/pcardext.so: Permission denied
/etc/hp/hplip.conf


My build-log is available at:
http://people.debian.org/~msp/hplip_0.8.2-1_i386.build

It also tends to place of lot of arch independant files under /usr/hplip, this
would be better has /usr/share/hplip, but the use of $(datadir) rather than
$(prefix) in a number of places.

What we did with davidp in hpoj was split up the install target into a
user_install (for base files and applications) and root_install (for /etc/ &
init.d files). The Debian package called user_install (honouring DETSDIR) to
place the base files in the correct location, but didn't call root_install.
Instead using the debian/rules to place /etc & init.d files.  Could you look
at a similar scheme for hplip as it would greatly help package maintainers
and would be transparent to other users of the upstream source.

Some other suggestions I have are:

- --- hplip-0.8.2.orig/prnt/Makefile.in
+++ hplip-0.8.2/prnt/Makefile.in
@@ -115,9 +115,9 @@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@

- -hplipdir = $(prefix)/hplip
- -prntdir = $(prefix)/hplip/prnt
- -cupsextdir = $(prefix)/hplip/prnt/cupsext
+hplipdir = $(datadir)/hplip
+prntdir = $(datadir)/hplip/prnt
+cupsextdir = $(datadir)/hplip/prnt/cupsext

 hplip_DATA =

- --- hplip-0.8.2.orig/base/Makefile.in
+++ hplip-0.8.2/base/Makefile.in
@@ -93,7 +93,7 @@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@

- -hplipdir = $(prefix)/hplip/base
+hplipdir = $(datadir)/hplip/base

 hplip_SCRIPTS = maint.py codes.py g.py mfpdtf2.py pml.py status.py async.py \
     database.py __init__.py mfpdtf.py service.py utils.py async_qt.py \
- --- hplip-0.8.2.orig/data/Makefile.in
+++ hplip-0.8.2/data/Makefile.in
@@ -95,11 +95,11 @@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@

- -xmldir = $(prefix)/hplip/data/xml
- -imagesdir = $(prefix)/hplip/data/images
- -pcldir = $(prefix)/hplip/data/pcl
- -ldldir = $(prefix)/hplip/data/ldl
- -psdir = $(prefix)/hplip/data/ps
+xmldir = $(datadir)/hplip/data/xml
+imagesdir = $(datadir)/hplip/data/images
+pcldir = $(datadir)/hplip/data/pcl
+ldldir = $(datadir)/hplip/data/ldl
+psdir = $(datadir)/hplip/data/ps

 ps_DATA = \
     ps/testpage.ps.gz
- --- hplip-0.8.2.orig/scan/Makefile.in
+++ hplip-0.8.2/scan/Makefile.in
@@ -93,7 +93,7 @@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@

- -hplipdir = $(prefix)/hplip/scan
+hplipdir = $(datadir)/hplip/scan

 hplip_SCRIPTS = __init__.py pml_scanner.py sane.py scanner.py scl.py
scl_scanner.py
 subdir = .

- --- hplip-0.8.2.orig/ui/Makefile.in
+++ hplip-0.8.2/ui/Makefile.in
@@ -93,7 +93,7 @@
 sysconfdir = @sysconfdir@
 target_alias = @target_alias@

- -hplipdir = $(prefix)/hplip/ui
+hplipdir = $(datadir)/hplip/ui

 hplip_SCRIPTS = \
     advancedinfoform_base.py \

- --- hplip-0.8.2.orig/pcard/Makefile.in
+++ hplip-0.8.2/pcard/Makefile.in
@@ -118,9 +118,9 @@

 noinst_PROGRAMS = ptest

- -hplipdir = $(prefix)/hplip
- -pcarddir = $(prefix)/hplip/pcard
- -pcardextdir = $(prefix)/hplip/pcard/pcardext
+hplipdir = $(datadir)/hplip
+pcarddir = $(datadir)/hplip/pcard
+pcardextdir = $(datadir)/hplip/pcard/pcardext

 hplip_DATA =

- --- hplip-0.8.2.orig/Makefile.in
+++ hplip-0.8.2/Makefile.in
@@ -63,27 +63,27 @@
           cd $$here/$$i; \
           $(MAKE) $(AM_MAKEFLAGS) install; \
        done
- -       $(install_script) $(PYTHON_SOURCES) $(PYTHON_SOURCES2)
$(DESTDIR)$(prefix)/$(PACKAGE)
+       $(install_script) $(PYTHON_SOURCES) $(PYTHON_SOURCES2)
$(DESTDIR)$(datadir)/$(PACKAGE)
        for i in $(PYTHON_SOURCES); do \
            newname=$${i%.*}; \
- -           mv $(DESTDIR)$(prefix)/$(PACKAGE)/$$i
$(DESTDIR)$(prefix)/$(PACKAGE)/$$newname; \
+           mv $(DESTDIR)$(datadir)/$(PACKAGE)/$$i
$(DESTDIR)$(datadir)/$(PACKAGE)/$$newname; \
        done
- -       $(mkinstalldirs) /etc/hp
- -       $(install_data) $(PACKAGE).conf /etc/hp/
- -       echo -e "\n[$(PACKAGE)]\nversion=$(VERSION)\njdprobe=0\n"
>> /etc/hp/$(PACKAGE).conf
- -       echo -e "[dirs]\nhome=$(DESTDIR)$(prefix)/$(PACKAGE)\n"
>> /etc/hp/$(PACKAGE).conf
+       $(mkinstalldirs) $(DESTDIR)/etc/hp
+       $(install_data) $(PACKAGE).conf $(DESTDIR)/etc/hp/
+       echo -e "\n[$(PACKAGE)]\nversion=$(VERSION)\njdprobe=0\n" >>
$(DESTDIR)/etc/hp/$(PACKAGE).conf
+       echo -e "[dirs]\nhome=$(DESTDIR)$(prefix)/$(PACKAGE)\n"
>>$(DESTDIR)/etc/hp/$(PACKAGE).conf


Mark


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBt1x0oCzanz0IthIRAlKQAJ9WCwm/X4l4SUB3YVYRVjFDa8QcuACdGekc
lwl4rUTV6raGsTeBhPTB8N8=
=PMGI
-----END PGP SIGNATURE-----


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/