[PATCH] ipw2200 1.1.4 broke radiotap header

Hi,

the radiotap headers created by 1.1.4 are currently broken. the TSFT flag has
been removed from rt_hdr.it_present. However, as the radiotap header is
variable length it is also necessary to remove the disabled field. The
attached patch accomplishes that.

Another oddity is that a noise field has been added to the ipw_rt, but it
is left unitialized in ipw_handle_data_packet_monitor(), and returns a
positive value in ipw_handle_promiscous_rx(). May be a substraction of
IPW_RSSI_TO_DBM is missing here, however, this results in -112dBm for me which
seems quite low with the notebook positioned next to the DECT station...

Stefan

--- ipw2200-1.1.4/ipw2200.h.old	2006-08-21 04:38:32.000000000 +0200
+++ ipw2200-1.1.4/ipw2200.h	2006-08-22 22:53:14.000000000 +0200
@@ -1158,7 +1158,6 @@ struct ipw_prom_priv {
  */
 struct ipw_rt_hdr {
 	struct ieee80211_radiotap_header rt_hdr;
-	u64 rt_tsf;		/* TSF */
 	u8 rt_flags;		/* radiotap packet flags */
 	u8 rt_rate;		/* rate in 500kb/s */
 	u16 rt_channel;		/* channel in mhz */
--- ipw2200-1.1.4/ipw2200.c.old	2006-08-21 14:22:53.000000000 +0200
+++ ipw2200-1.1.4/ipw2200.c	2006-08-22 22:54:02.000000000 +0200
@@ -7766,7 +7766,6 @@ static void ipw_handle_data_packet_monit
 
 	/* Zero the flags, we'll add to them as we go */
 	ipw_rt->rt_flags = 0;
-	ipw_rt->rt_tsf = 0ULL;
 
 	/* Convert signal to DBM */
 	ipw_rt->rt_dbmsignal = antsignal;
@@ -7978,7 +7977,6 @@ static void ipw_handle_promiscuous_rx(st
 
 	/* Zero the flags, we'll add to them as we go */
 	ipw_rt->rt_flags = 0;
-	ipw_rt->rt_tsf = 0ULL;
 
 	/* Convert to DBM */
 	ipw_rt->rt_dbmsignal = signal;

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642