Re: [RFT] ipw2200: fix ucode assertion for RX queue overrun
"Chatre, Reinette" <[email protected]> Thu, 14 Feb 2008 13:28:50 -0800
| Newsgroups | gmane.linux.drivers.ipw2100.devel,gmane.linux.kernel.wireless.general |
|---|---|
| Message-ID | <D936D925018D154694D8A362EEB0892003ABC9AF@orsmsx416.amr.corp.intel.com> |
On , Christian Fredriksson wrote: > assertion for RX queue overrun > > Sebastian Siewior wrote: >> * Dan Williams | 2008-02-11 09:27:50 [-0500]: >> >> >>> Restock the RX queue when there are a lot of unused frames so that >>> the RX ring buffer doesn't overrun, causing a ucode assertion. >>> Backport of patch "iwlwifi: fix ucode assertion for RX queue >>> overrun". >>> >>> Signed-off-by: Dan Williams <[email protected]> >>> >> Tested-by: Sebastian Siewior <[email protected]> >> >> >>> Sebastian, can you test and ensure that this works for you? Also, >>> can >>> >> Yep, it does. >> >> >>> you do some throughput testing to ensure that this patch doesn't >>> cause a throughput regression? Thanks! >>> >> 00:49:41 (666.64 KB/s) - `/dev/null' saved [122563640/122563640] >> >> this was a wget from the inet and it hits almost my cap. Currently I >> don't have another local machine where I can test a "local" transfer. >> >> Is this okey for you? >> >> Sebastian >> >> >> > The patch seem stable. Throughput are ok. > > sftp> get 1001_20071125080100.mpg > Fetching /myth/tv/1001_20071125080100.mpg to 1001_20071125080100.mpg > /myth/tv/1001_20071125080100.mpg 100% 1120MB 2.6MB/s > 07:16 sftp> > > /Christian Sounds great! Dan, could you please submit a final version - I'll ack it. Thank you very much Reinette ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/