Re: ipw2200: queue direct scans
Zhu Yi <[email protected]> Tue, 22 Apr 2008 09:50:43 +0800
| Newsgroups | gmane.linux.drivers.ipw2100.devel,gmane.linux.kernel.wireless.general |
|---|---|
| Organization | Intel Corp. |
| Message-ID | <[email protected]> |
On Mon, 2008-04-21 at 13:49 -0400, Dan Williams wrote: > When another scan is in progress, a direct scan gets dropped on the > floor. However, that direct scan is usually the scan that's really > needed by userspace, and gets stomped on by all the broadcast scans > the > ipw2200 driver issues internally. Make sure the direct scan happens > eventually, and as a bonus ensure that the passive scan worker is > cleaned up when appropriate. > > The change of request_passive_scan form a struct work to struct > delayed_work is only to make the set_wx_scan() code a bit simpler, > it's > still only used with a delay of 0 to match previous behavior. > > Signed-off-by: Dan Williams <[email protected]> I agree with you the idea to split the current active request_scan into active direct scan and active broadcast scan. But can you merge your ipw_request_direct_scan_helper into ipw_request_scan_helper so that we don't duplicate the code? Thanks, -yi ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone