Re: [PATCH v2] mtd: spi-nor: scope the exclusive RWW lock
"Michael Walle" <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.linux.drivers.mtd,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
On Tue Aug 11, 2026 at 6:13 AM CEST, Runyu Xiao wrote:
> spi_nor_rww_start_exclusive() is used as the wait_event_killable()
> condition for RWW access. When RWW is busy, it can return false while
> still holding nor->lock, which blocks spi_nor_rww_end_exclusive() from
> clearing the RWW state.
>
> Use guard(mutex) here so nor->lock is released before the condition
> returns, while the state flags still hand off ownership to the caller.
> This keeps the mutex scope aligned with the other RWW start helpers.
>
> Fixes: 03e7bb864d9a ("mtd: spi-nor: use scope-based mutex cleanup helpers")
> Cc: [email protected]
> Signed-off-by: Runyu Xiao <[email protected]>
There were questions in v1. Please answer them. Don't just ignore
them and just throw a new version of your patch at us. We put time
and effort into maintaining. See also [1].
-michael
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html