RE: [PATCH v3 18/23] mtd: spi-nor: winbond: Add support for W25Q12RV-M

Hi Miquel,

> There is an ID collision with the chip of same density from the JV
> family. Both chips are very similar in practice, it is mostly a matter
> of electrical differences (mostly power consumption being lower).
> 
> As a significant difference, RV chips identify themselves as supporting
> the new SFDP (rev F) field which forces an alternate write SR2
> opcode (0x31).
> 
> Signed-off-by: Miquel Raynal <[email protected]>
> ---
> + cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
> ef7018
> + cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
> winbond
> + xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 534644500a0100ff00080117800000ffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffe520f9ffffffff0344eb086b083b42bbfeffffffffff
> 0000ffff44eb0c200f5210d80000142a010186e114c1e96376337a757a75
> f7a2d55c39f66dffe930f880000000000000ac0000000000f7f5ffff0f00
> 0000060d44bd27ed080d
> + sha256sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 94b52d6e903a2046e144eab0760384b6932c6fdbfec17eb7336f1778c3898daf  /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> + cat /sys/kernel/debug/spi-nor/spi0.0/capabilities
> Supported read modes by the flash
>  1S-1S-1S
>   opcode        0x03
>   mode cycles   0
>   dummy cycles  0
>  1S-1S-2S
>   opcode        0x3b
>   mode cycles   0
>   dummy cycles  8
>  1S-2S-2S
>   opcode        0xbb
>   mode cycles   2
>   dummy cycles  2
>  1S-1S-4S
>   opcode        0x6b
>   mode cycles   0
>   dummy cycles  8
>  1S-4S-4S
>   opcode        0xeb
>   mode cycles   2
>   dummy cycles  4
>  4S-4S-4S
>   opcode        0xeb
>   mode cycles   2
>   dummy cycles  4
> 
> Supported page program modes by the flash
>  1S-1S-1S
>   opcode        0x02
>  1S-1S-4S
>   opcode        0x32
> + cat /sys/kernel/debug/spi-nor/spi0.0/params
> name            (null)
> id              ef 70 18 00 00 00
> size            8.00 MiB

Is this correct?
This part should be 16MB(128Mb).

Thanks,
Takahiro