Re: Bug? 2.4.24 module/networking Kernel driver/net/r8169.c freeze

Francois Romieu <[email protected]> Sat, 17 Jan 2004 14:23:07 +0100
Newsgroups gmane.linux.network,gmane.linux.kernel,gmane.linux.drivers.realtek.devel
Message-ID <[email protected]>
--NzB8fVQJ5HfG6fxh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

[email protected] <[email protected]> :
[...]
> 1. short: smb over tcp delays > 5 sec; flood ping to machine --> machine 
> freeze

Please apply attached patch and see 1) if Tx traffic stops 2) if something
appears in dmesg.

[email protected] added to Cc:.

--
Ueimor

--NzB8fVQJ5HfG6fxh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="r8169-debug.patch"

--- r8169.c-realtek	2004-01-17 14:14:50.000000000 +0100
+++ r8169.c-debug	2004-01-17 14:17:25.000000000 +0100
@@ -1290,6 +1290,11 @@ static void rtl8169_tx_interrupt (struct
 	dirty_tx = priv->dirty_tx;
 	tx_left = priv->cur_tx - dirty_tx;
 
+	if (entry + tx_left > NUM_TX_DESC) {
+		printk(KERN_ERR, "r8169 bug. Please mail [email protected]\n");
+		return;
+	}
+
 	while (tx_left > 0) {
 		if( (priv->TxDescArray[entry].status & OWNbit) == 0 ){
 			dev_kfree_skb_irq( priv->Tx_skbuff[dirty_tx % NUM_TX_DESC] );

--NzB8fVQJ5HfG6fxh--