Re: [New Driver]: usbvideo2 webcam core + pac207 driver using it.

On Thu, 3 Apr 2008 14:27:28 -0700, Brandon Philips <[email protected]> wrote:

> > struct pac207_decompress_table_t {
> > 	u8 is_abs;
> > 	u8 len;
> > 	s8 val;
> > };
> 
> Why add the _t?

What Brandon is trying to say here is "add _t to typedefs, don't
add _t to structs". In kernel we use explicit structs.

> > #define CLIP(color) (unsigned char)(((color)>0xFF)?0xff:(((color)<0)?0:(color)))
> 
> Add a comment about what this is doing?  Could you just do it as a
> static function instead?

The macro itself is too trivial to be commented, IMHO, but I have
to ask just what it is doing there. It is only applied to
precomputed values from pac207_decompress_table, as far as I see.
So, they cannot be out of range. Or can they?

-- Pete