Re: Bad PCI IDs-Names table in 3c59x.c

On 03.29, Andrew Morton wrote:
> "J.A. Magallon" <[email protected]> wrote:
> >
> > +	{ 0x10B7, 0x1201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CH_3C982A },
> > +	{ 0x10B7, 0x1202, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CH_3C982B },
> 
> OK.  I'm a bit mystified as to how these ID's got lost.  They do not appear
> in Donald's latest driver, so I assume the catchall PCI ID match picked them
> up.  
> 
> The mainstream PCI code does not have the catchall capability.
> 
> Keeping that big device table in sync is a real pain, which is why it has
> been kept grouped into batches of five entries.  
> 
> Donald's driver describes 0x9805 as a "3c982 Server Tornado".  What makes you
> think it is a "3c980 Python-T"?
> 

That is what is labeled in the card, and as I said before, that it has _only_
one RJ45 connector, so it hardly can be a "Dual Port" card ;).

pci.ids has this:

10b7  3Com Corporation
    ...
    9805  3c980-TX 10/100baseTX NIC [Python-T]
        10b7 1201  3c982-TXM 10/100baseTX Dual Port A [Hydra]
        10b7 1202  3c982-TXM 10/100baseTX Dual Port B [Hydra]
        10b7 9805  3c980 10/100baseTX NIC [Python-T]

and my card gives:

(lspci -n)
00:12.0 Class 0200: 10b7:9805 (rev 78)
(lspci -v)
00:12.0 Ethernet controller: 3Com Corporation 3c980-TX 10/100baseTX NIC [Python-T] (rev 78)
        Subsystem: 3Com Corporation: Unknown device 1000

Donald's driver has:
    { 0x10B7, 0x9800, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CH_3C980 },
    { 0x10B7, 0x9805, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CH_3C9805 },
...
    {"3c980 Cyclone",
     PCI_USES_IO|PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM, 128, },
    {"3c982 Dual Port Server Cyclone",
     PCI_USES_IO|PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM, 128, },

ie, associates 0x10B7, 0x9805 with "3c982 Dual Port Server Cyclone".


-- 
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.1 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))