Re: Re: fr1-2.16 patch for 2.6.10 kernel

Peter T. Breuer a écrit :
> "Also sprach denis bonnenfant:"
> 
>>I tried this :
> 
> 
> That's the wrong place.
> 
> 
>>		if (mddev->degraded) {
>>			ITERATE_RDEV(mddev,rdev,rtmp)
> 
> 
> The check must be HERE. Before rdev is dereferenced.

Oh yes...

I test with :

if (mddev->degraded) {
   ITERATE_RDEV(mddev,rdev,rtmp) {
	if (!mddev) {
	printk(KERN_INFO "md: *****BUG***mddev***********!!!\n");
	break;
	}
	printk(KERN_INFO "md: *****test*************!!!\n");
	if (!rdev) {
	printk(KERN_INFO "md: *****BUG**rdev*************!!!\n");
	break;
	}
	if (rdev->raid_disk < 0
	 && !rdev->faulty) {

and then :

md: *****test*************!!!
Unable to handle kernel NULL pointer dereference at virtual address 00000004
  printing eip:
f88ac3d7
*pde = 00000000
Oops: 0000 [#1]

So i'm very confused...