Re: Re: fr1-2.16 patch for 2.6.10 kernel

P> so please expand the loop as follows:
> 
>     rtmp = mddev->disks.next;
>     while (1) {
> 
>         printk(KERN_INFO "md %d: ** mddev=%p rdev=%p\n", __LINE__, mddev, rdev);
> 
>         rdev = list_entry(rtmp, mdk_rdev_t, same_set);
>         rtmp = rtmp->next;
>         if (rtmp->prev == &mddev->disks)
>             break;
> 
>         if (rdev->raid_disk < 0 && !rdev->faulty) {
>             if (mddev->pers->hot_add_disk(mddev,rdev))
>                 spares++;
>             else
>                 break;
>         }
>     }
> 

Done

first hotadd :

md 3875: ** mddev=f7feee80 rdev=f7feee90
RAID1 conf printout:
  --- wd:1 rd:2
  disk 0, wo:1, o:1, dev:sda1
  disk 1, wo:0, o:1, dev:sda2
md 3875: ** mddev=f7feee80 rdev=f7ff6c40
md 3875: ** mddev=f7feee80 rdev=f7ff6c80


second one :


md 3875: ** mddev=f7feee80 rdev=f7feee90
Unable to handle kernel NULL pointer dereference at virtual address 00000004
  printing eip:
f88ac3d7
*pde = 00000000
Oops: 0000 [#1]
PREEMPT
Modules linked in: raid1 bitmap md epic100 usbkbd parport_pc lp parport
CPU:    0
EIP:    0060:[<f88ac3d7>]    Not tainted
EFLAGS: 00010006   (2.6.8-enbd-fr1-debug1)
EIP is at raid1_add_disk+0x4f/0xf8 [raid1]
eax: 00000000   ebx: f798a9c0   ecx: c0431cdc   edx: f7964e80
esi: f7ff4880   edi: 00000000   ebp: f7feee80   esp: f7775f30
ds: 007b   es: 007b   ss: 0068
Process md0_raid1 (pid: 2551, threadinfo=f7774000 task=f729f930)
Stack: f7ff4880 f7ff6c80 f7feee80 f7feee90 00000000 f7964e80 f88b9cbd f7feee80
        f7ff4880 f7ff47c0 f7774000 f7775fdc f7774000 f7feef0c 00000000 f88ac9f5
        f7feee80 f7ff47c0 f7774000 f7775fdc f7774000 00000000 f729f930 00000000