Re: Re: fr1-2.16 patch for 2.6.10 kernel

denis bonnenfant a écrit :
>> Ahhhhh ... it's in raid1_add_disk, not hot_add_disk. Oookaaaayyyyyy..
>>
>> One quarter way through. Hmmm - that could be me. Can you instrument?
>>
> So, where does it crashes in raid1_add_disk ?
> 
> md 3886: ** mddev->pers=f88a8c20
> md 3887: ** mddev->pers->hot_add_disk=f88a5388
> raid1 1046: ** mddev=f7fc8480 rdev=f7ff9680 mirror=0
> Unable to handle kernel NULL pointer dereference at virtual address 
> 00000004
>  printing eip:
> f88a53ec
> *pde = 00000000
> Oops: 0000 [#1]
> 
> it's here :
> 
> #ifdef CONFIG_MD_FR1
>             /*
>              * allow a disk which has only been set faulty but not
>              * removed yet to be reinserted, thus triggering a hot
>              * repair.
>              */
>         printk(KERN_INFO "raid1 %d: ** mddev=%p rdev=%p mirror=%d\n", 
> __LINE__, mddev, rdev, mirror);
>         if ( !(p=conf->mirrors+mirror)->rdev
>                     || p->rdev == rdev
>                     || p->rdev->bdev->bd_inode->i_rdev == 
> rdev->bdev->bd_inode->i_rdev) {
> 
> I'm going to  expand this test to find exactly where is the problem..

it's p->rdev.