Re: Re: fr1-2.16 patch for 2.6.10 kernel
"Peter T. Breuer" <[email protected]>
| Newsgroups | gmane.linux.enbd.general |
|---|---|
| Message-ID | <[email protected]> |
"Also sprach Peter T. Breuer:"
> static unsigned char *
> bitmap_alloc_page(struct bitmap *bitmap) {
> unsigned char *page;
>
> page = kmem_cache_alloc(bitmap_page_cache, GFP_KERNEL);
> /* PTB zeroing is done by the constructor and only
> * clean pages are returned to the cache
> */
> return page;
> }
>
> Well, maybe that comment is no longer accurate. Add a
>
> memset(page, 0, PAGE_SIZE);
Uh,
if (page) memset(page, 0, PAGE_SIZE);
The alloc is not guaranteed.
Peter