Re: patch fr1-2.17 does not work with kernel 2.4.30

On Sat, 9 Apr 2005 00:59:12 +0200 (MET DST)
"Peter T. Breuer" <[email protected]> wrote:

> "Also sprach ptb:"
> > "Also sprach ptb:"
> > I'm afraid I can't see a UML patch for anything more recent than
> > 2.4.27. I can try that. Meanwhile I suggest the printk route!
> 
> And it looks like the 2.4.27 UML patch will not compile in my libc
> environment. I even think I've tried that before now.
> 
> Maybe somebody can give me a 2.4.27 uml kernel? Better, 2.4.30.

Hi Peter,

via debugging I found out your raid1.c patch is in trouble regarding spinlocks:

At this point (around line 2050) point 8 is reached but not 9

#if defined(CONFIG_MD_FR1) || defined(CONFIG_MD_FR1_MODULE)
        printk (KERN_WARNING "raid1.c: 8\n");
        /* printout info from time to time */
        spin_lock_irq(&conf->segment_lock);
        printk (KERN_WARNING "raid1.c: 9\n");

I guess the cause of it all is this (around line 1930)

        conf->cnt_ready++;
#if defined(CONFIG_MD_FR1) || defined(CONFIG_MD_FR1_MODULE)
        /* PTB hold the segment lock a bit longer for more setup ...*/
        printk (KERN_WARNING "raid1.c: 1\n");
#else
        spin_unlock_irq(&conf->segment_lock);  
#endif /* CONFIG_MD_FR1 */

In fact you seem to never release this lock again later on...

Where/how did you intend to release it? As I have no insider knowledge about
the code itself I cannot just place some unlock somewhere, not knowing what it
really protects...

Regards,
Stephan