Re: Re: fr1 with iSCSI on 2.6.11?

Peter T. Breuer wrote:

>Carlos Knowlton <[email protected]> wrote:
>  
>
>>1.  Do you have any plans to update the fr1 patch for the 2.6 kernels to 
>>patch cleanly with 2.6.11?  I get some success, but lots of "hunk 
>>failed" messages from "patch -p0 < ./fr1_2.6_patch_file_name.patch".
>>    
>>
>
>Well, that would likely result in something of dubious parentage, since
>it is "-p1" that is used by convention, and the patch is constructed to
>be used that way, from within the linux source directory.
>
>Last I heard, the 2.6.8.1 patch applied fairly well to 2.6.11  ... I
>certainly have the 2.6.11 code hanging around that I could try it on.
>
>  
>
well okay, with the "patch -p1" with linux-2.6.11.11, I do get better 
mileage, but still some "failed hunks".  Here's my output:

-----------------begin patch----------------------
[root@TeranII linux-2.6.11.11]# patch -p1 < ../fastraid/linux-2.6.8.1.patch
patching file drivers/md/raid1.c
Hunk #2 succeeded at 53 with fuzz 2 (offset -4 lines).
Hunk #3 FAILED at 236.
Hunk #4 succeeded at 273 (offset -28 lines).
Hunk #5 succeeded at 370 (offset -4 lines).
Hunk #6 succeeded at 375 (offset -28 lines).
Hunk #7 succeeded at 539 (offset -3 lines).
Hunk #8 succeeded at 540 (offset -28 lines).
Hunk #9 succeeded at 692 (offset 27 lines).
Hunk #10 succeeded at 675 with fuzz 2 (offset -28 lines).
Hunk #11 succeeded at 760 (offset 38 lines).
Hunk #12 FAILED at 792.
Hunk #13 succeeded at 805 (offset -28 lines).
Hunk #14 succeeded at 987 (offset 38 lines).
Hunk #15 succeeded at 942 (offset -28 lines).
Hunk #16 succeeded at 1035 (offset 38 lines).
Hunk #17 FAILED at 1081.
Hunk #18 FAILED at 1134.
Hunk #19 succeeded at 1150 (offset -29 lines).
Hunk #20 FAILED at 1248.
Hunk #21 succeeded at 1388 (offset 44 lines).
Hunk #22 succeeded at 1341 (offset -29 lines).
Hunk #23 FAILED at 1376.
Hunk #24 succeeded at 1491 with fuzz 1 (offset 44 lines).
Hunk #25 succeeded at 1562 (offset -29 lines).
Hunk #26 succeeded at 1768 (offset 46 lines).
Hunk #27 succeeded at 1737 (offset -29 lines).
Hunk #28 succeeded at 1835 (offset 47 lines).
6 out of 28 hunks FAILED -- saving rejects to file drivers/md/raid1.c.rej
patching file drivers/md/bitmap.h
patching file drivers/md/bitmap.c
patching file drivers/md/md.c
Hunk #4 succeeded at 203 (offset 1 line).
Hunk #5 succeeded at 391 (offset -5 lines).
Hunk #6 succeeded at 412 (offset 1 line).
Hunk #7 succeeded at 627 (offset -4 lines).
Hunk #8 succeeded at 722 (offset 1 line).
Hunk #9 succeeded at 924 with fuzz 2 (offset 10 lines).
Hunk #10 succeeded at 976 (offset 1 line).
Hunk #11 succeeded at 1059 (offset 11 lines).
Hunk #12 succeeded at 1172 (offset 1 line).
Hunk #13 succeeded at 1195 (offset 11 lines).
Hunk #14 succeeded at 1217 (offset 5 lines).
Hunk #15 succeeded at 1234 (offset 11 lines).
Hunk #16 succeeded at 1253 (offset 5 lines).
Hunk #17 succeeded at 2346 (offset -47 lines).
Hunk #18 succeeded at 2419 (offset 2 lines).
Hunk #19 succeeded at 2438 (offset -47 lines).
Hunk #20 succeeded at 2568 (offset 2 lines).
Hunk #21 succeeded at 3547 (offset -33 lines).
Hunk #22 succeeded at 3664 with fuzz 2 (offset 30 lines).
Hunk #23 succeeded at 3631 with fuzz 2 (offset -33 lines).
Hunk #24 succeeded at 3733 (offset 32 lines).
Hunk #25 FAILED at 3766.
Hunk #26 succeeded at 3815 with fuzz 1 (offset -33 lines).
Hunk #27 FAILED at 3832.
Hunk #28 succeeded at 3949 (offset 29 lines).
Hunk #29 succeeded at 4076 with fuzz 2 (offset -38 lines).
2 out of 29 hunks FAILED -- saving rejects to file drivers/md/md.c.rej
patching file drivers/md/Kconfig
Hunk #1 succeeded at 103 with fuzz 2 (offset 18 lines).
patching file drivers/md/Makefile
Hunk #1 succeeded at 25 with fuzz 2 (offset 3 lines).
patching file include/linux/raid/raid1.h
Hunk #1 succeeded at 50 (offset 1 line).
Hunk #3 succeeded at 112 (offset 1 line).
patching file include/linux/raid/md_p.h
Hunk #2 FAILED at 228.
1 out of 2 hunks FAILED -- saving rejects to file 
include/linux/raid/md_p.h.rej
patching file include/linux/raid/md_k.h
Hunk #1 succeeded at 238 (offset 8 lines).
------------------end patch--------------------

Thanks!
Carlos

>>2.  Do you see any problem with using fr1 to mirror other network block 
>>device drivers, say, iSCSI for instance?
>>    
>>
>
>Well, they ideally need to have support for the
>
>BLKMDNTFY
>BLKMDUNTFY
>BLKMDRGTR
>
>ioctls added.
>
>The first two are advisories about being included or removed from a raid
>array, allowing the driver to change its settings to suit it better (in
>the case of enbd, it switches to showing all errors and not blocking on
>network disconnect).
>
>The third passes the address of a callback function that accepts the
>HOT_ADD_DISK and SET_DISK_FAULTY args, to allow the driver to announce
>that it is respectively ell again and/or ill again up to the raid
>device.
>
>Peter
>
>_______________________________________________
>ENBD mailing list
>[email protected]
>http://lists.community.tummy.com/mailman/listinfo/enbd
>  
>