Re: Re: fr1 with iSCSI on 2.6.11?

"Also sprach denis:"
> denis a _crit :
> 
> > and now another problem while compiling enbd and 2.6.11.12 (using 
> > 2.6.8.1 patch, i haven't tried to compile outside of the kernel) :
> > ...
> > CC [M]  drivers/block/enbd/enbd_base.o
> > drivers/block/enbd/enbd_base.c:3471: conflicting types for 
> > `wait_for_completion_timeout'
> > include/linux/ :33: previous declaration of `wait_for_completion_timeout'
> > drivers/block/enbd/enbd_base.c:4295: warning: `enbd_read_block_0' 
> > defined but not used
> 
> 
> in enbd_base.c we have long  and  in completion.h unsigned long.  I 

Are you saying that enbd_bse.c redefines a function which is now given in
completion.h?  Yes ...  it does.  Well, then the one in enbd_base.c is
the one that is wanted.


> changed the type in enbd_base;c, but i'm not really sure.

Don't (but it doesn't matter - there is no difference in size and the
result is passed into an int anyway).

   int err;
   ...
   err = wait_for_completion_timeout(&ioctl_info->x, timeout);

so it will be truncated modulo sign. The sign needs to be preserved, so
"long" is correct as the declaration. And it matches the result that is
constructed within the function.


> Now some problems in md :
> 
>   CC [M]  drivers/md/raid1.o
> drivers/md/raid1.c: In function `sync_request':
> drivers/md/raid1.c:1500: warning: passing arg 1 of `md_sync_acct' from 
> incompatible pointer type

Really? What would that be? There are only 1433 lines in my copy of
raid1.c! The only calls I see are

   md_sync_acct(mirror->rdev->bdev, nr_sectors);
   md_sync_acct(conf->mirrors[i].rdev->bdev, wbio->bi_size >> 9); 

and those self-evidently have the same type first arg! Care to
elaborate?


>   CC [M]  drivers/md/bitmap.o
> drivers/md/bitmap.c: In function `bitmap_destr':
> drivers/md/bitmap.c:121: `MOD_DEC_USE_COUNT' undeclared (first use in 
> this function)

Has it been deprecated? what does one call then? What about
MOD_INC_USE_COUNT?


> drivers/md/bitmap.c:121: (Each undeclared identifier is reported only once
> drivers/md/bitmap.c:121: for each function it appears in.)
> drivers/md/bitmap.c: In function `bitmap_init':
> drivers/md/bitmap.c:831: `MOD_INC_USE_COUNT' undeclared (first use in 
> this function)

Oh, OK.

Well, comment the uses or substitute something else ...

> 
> This macro seems not to be defined before...
> well... It has been suppressed in this kernel version !
> 
> I just comment the lines, as i have not found the equivalent in 
> modules.h....

Weird. OK.

> now it compiles.

Good.

Peter