Re: enbd_ioctl 2.6.9 kernel fails to modprobe enbd - seg fault

Dear Peter,


> Note that the report does not corespond to the code:
> 
> > Unable to handle kernel NULL pointer dereference at virtual address
> > 000003ae
> >  printing eip:

<snip>

I'll get back on this stuff when I've done the reboot and insmod with a
fresh dmesg.

We can do a comparison.

Interestingly, - the size of the module is different now. (After I fixed
the gcc thing again.)

I think that was killing it.

> It says it is called by init_module, which it isn't. It's in 
> enbd_init_queue. So that has been inlined.
> 
>    static void
>    enbd_init_queue (struct enbd_device *lo, struct request_queue *queue)
>    {
> 
>    // PTB - set up kernel queue struct with default methods
>            blk_queue_max_sectors (queue, buf_sectors);     /* max per request */
> 
> I would suggest checking for sanity of the queue arg in that function.
> Do a printk if it is less than 4K.
> 
> Peter

Kind regards

Derek.