(EVMS, feisty) dm-bbr.c won't compile on amd64

Hi folks,

I was trying to rebuild a Xen kernel package on Ubuntu this morning,
after applying the EVMS patches (dm-bbr and bd-claim), and found that
the dm-bbr module won't build on amd64.

The salient details are:

  Ubuntu 7.04 (feisty) current pre-release
  xen-image-2.6.19-4-generic-amd64 (from xen-source_2.6.19-2ubuntu7)
  linux-patch-evms (from linux-patch-evms_2.5.5-18ubuntu3)

The process was:

  cd /tmp
  apt-get source xen-image-2.6.19-4-generic-amd64
  cd /tmp/xen-source-2.6.19/debian/patches/
  cat >> 00list
    # EVMS patches
    evms-2.6-dm-bbr.diff
    evms-2.6-bd-claim.diff
  cp -a /usr/src/kernel-patches/diffs/evms-*/2.6* .
  gunzip *gz
  mv 2.6-bd-claim.patch evms-2.6-bd-claim.diff
  mv 2.6-dm-bbr.patch evms-2.6-dm-bbr.diff
  cd ../..
  debian/rules build
  [ ... lots of stuff ... ]

The build chugged along for 10 minutes and then fell over, with the
following errors:

  drivers/md/dm-bbr.c: In function "validate_bbr_table_sector":
  drivers/md/dm-bbr.c:212: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:213: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:220: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:229: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:230: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c: In function "bbr_insert_remap_entry":
  drivers/md/dm-bbr.c:299: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c: In function "bbr_table_to_remap_list":
  drivers/md/dm-bbr.c:338: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:337: warning: unused variable "b"
  drivers/md/dm-bbr.c: In function "bbr_setup":
  drivers/md/dm-bbr.c:448: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c: In function "bbr_io_remap_error":
  drivers/md/dm-bbr.c:505: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:514: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:551: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:560: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:483: warning: unused variable "b"
  drivers/md/dm-bbr.c: In function "bbr_endio":
  drivers/md/dm-bbr.c:768: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:763: warning: unused variable "b"
  drivers/md/dm-bbr.c: In function "bbr_status":
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 5 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 6 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 7 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 8 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 9 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 10 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 5 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 6 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 7 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 8 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 9 has type "u64"
  drivers/md/dm-bbr.c:910: warning: format "%lu" expects type "long unsigned int", but argument 10 has type "u64"
  drivers/md/dm-bbr.c: In function "dm_bbr_init":
  drivers/md/dm-bbr.c:933: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:941: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:949: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:957: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:964: error: expected ")" before "DM_MSG_PREFIX"
  drivers/md/dm-bbr.c:971: error: expected ")" before "DM_MSG_PREFIX"
  make[3]: *** [drivers/md/dm-bbr.o] Error 1

I'm going to try Daniel Drake's dm-bbr patch from January 27[1] and
February 10[2] of this year (see evms-devel list archives) as some of
the code clean-up may correct the problem.  If anyone knows better,
please let me know.

Cheers,

Andrew.

[1]  http://marc.info/?l=evms-devel&m=117009106114951&w=2
[2]  http://marc.info/?l=evms-devel&m=117106934119158&w=2

-- 
Andrew Shugg <[email protected]>                   http://www.neep.com.au/

"Just remember, Mr Fawlty, there's always someone worse off than yourself."
"Is there?  Well I'd like to meet him.  I could do with a good laugh."

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Evms-devel mailing list
[email protected]
To subscribe/unsubscribe, please visit:
https://lists.sourceforge.net/lists/listinfo/evms-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFGGGKmBPZqzJuQGysRApvaAKCmaMpVmeCKsneFrH3JerRwkM3I2wCgqRwt
/xaHgxHd0yikzqru1GThZsM=
=FN3x
-----END PGP SIGNATURE-----